search

openshift / verification-tests

Blackbox test suite for OpenShift.
GNU General Public License v3.0
52 stars 170 forks source link

remove @critical to some persistent_volume cases #3622

Closed duanwei33 closed 4 months ago

duanwei33 commented 4 months ago

I don't believe these PV negative cases warrant a "critical" designation. We don't need to include them in the critical CI profiles, so let's remove them.

Phaow commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

@duanwei33: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
chao007 commented 4 months ago

/lgtm

pruan-rht commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chao007, Phaow, pruan-rht

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[features/storage/OWNERS](https://github.com/openshift/verification-tests/blob/master/features/storage/OWNERS)~~ [pruan-rht] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment