openshift / verification-tests

Blackbox test suite for OpenShift.
GNU General Public License v3.0
52 stars 170 forks source link

[OCPQE-22132] Skip auth missing ImageRegistry baselinecap test failure #3623

Closed dpuniaredhat closed 4 months ago

dpuniaredhat commented 4 months ago

@xingxingxia Please help review this PR to skip auth cap failure due to missing ImageRegistry baseline capabilities

Below is the execution result: With enabled baselinecap ImageRegistry: https://privatebin.corp.redhat.com/?d9be5ce58aa8e22a#Q2qxSXkv2qp7XXpz28QBnDVTJrrvL5m5zg64KEZb9t4

Without enabled baselinecap ImageRegistry: https://privatebin.corp.redhat.com/?44a4ba7072b0638f#BY2ELCtn3CZem6rFAn7xZrB9LUBmCr4qaYiXnoTvuuxP

dpuniaredhat commented 4 months ago

/assign @xingxingxia

pruan-rht commented 4 months ago

@dpuniaredhat now that my PR has been merged, if you fetch from master, then you can remove the file check_basecap.rb from this PR

openshift-ci[bot] commented 4 months ago

@dpuniaredhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dpuniaredhat commented 4 months ago

Here is the execution Result:

With basecap enabled : job/Runner-v3-smoke/7594/console Without basecap enabled : job/Runner-v3-smoke/7595/console

liangxia commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[features/cli/OWNERS](https://github.com/openshift/verification-tests/blob/master/features/cli/OWNERS)~~ [liangxia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment