openshift / verification-tests

Blackbox test suite for OpenShift.
GNU General Public License v3.0
52 stars 170 forks source link

update xpath for check_zoom_value and choose_zoom_value for OCP-24097 #3641

Closed juzhao closed 3 months ago

juzhao commented 3 months ago

see https://issues.redhat.com/browse/OCPQE-24183, due to 4.17 UI change, update xpath for check_zoom_value action to use query-browser__wrapper class and the xpath should be update for choose_zoom_value action and actions it's invoked, same to use query-browser__wrapper class

choose_zoom_value:
  action: click_chart_zoom_dropdown
  action: click_zoom_value_button 

4.17.0-0.nightly-2024-08-13-031847 runner job passed

juzhao commented 3 months ago

/retitle update xpath for check_zoom_value and choose_zoom_value for OCP-24097

Tai-RedHat commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

@juzhao: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
juzhao commented 3 months ago

@pruan-rht please help to approve

liangxia commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia, Tai-RedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[lib/rules/web/admin_console/OWNERS](https://github.com/openshift/verification-tests/blob/master/lib/rules/web/admin_console/OWNERS)~~ [liangxia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
liangxia commented 3 months ago

BTW, the bot states,

Once this PR has been reviewed and has the lgtm label, please ask for approval from [juzhao](https://github.com/juzhao).

You should be able to self approve the PR.