search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Move VPA from channel per version to stable channel #106

Closed joelsmith closed 3 years ago

joelsmith commented 3 years ago

/retest

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
joelsmith commented 3 years ago

/hold

joelsmith commented 3 years ago

/hold cancel I was too slow to add /hold but we'll revert any/all of these changes if necessary. The question we still have is about whether on manifests/dirname, does dirname refer to a version or a channel name. So we may need to go back to how we had it before for much of this change. Thanks @wangchen615 for catching that.