search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Fix inconsistency between RBAC and CSV required permissions #11

Closed jwforres closed 4 years ago

jwforres commented 4 years ago

... and also fix a typo in CRB name

I wasn't sure whether the required permissions in the CSV were correct, or the RBAC in the RBAC file were correct, but the RBAC was not providing sufficient permissions and OLM was rejecting installation of the operator. If the required permissions are what is not correct I can fix those instead.

joelsmith commented 4 years ago

Our original plan was to install via CSV, but now that we will be installing via OLM, the CSV install files are obsolete. I'm planning to remove them as soon as the OLM install works. As I understand it, installation via OLM is blocked because we don't have images built for it yet. If you would like to try out my development images, I can provide instructions on how to install them using a custom catalog source that I built for testing.

jwforres commented 4 years ago

@joelsmith I created my own custom CatalogSource off of the manifest content in the /manifests directory in master, that operator content won't deploy as is, it fails requirements on all of the RBAC checks, hence why i tried using the RBAC yaml to set up the RBAC. Do you have a different set of manifests in a development branch?

joelsmith commented 4 years ago

I do have a different set of manifests, but the only difference is the images that the CSV references. Instead of quay.io/openshift/vertical-pod-autoscaler-operator:4.4 it uses quay.io/joelsmith/openshift-vertical-pod-autoscaler-operator:latest and instead of quay.io/openshift/vertical-pod-autoscaler:4.4 it has quay.io/joelsmith/openshift-vertical-pod-autoscaler:latest. I'm not sure that the ones at quay.io/openshift are being updated and I wasn't going to worry about it until the ART team gets our build updated to do images for OLM.

The ART team is in the process of switching our images over and until we get the new ones, I haven't been using the ones that they build. Here's my catalog source image which references my development images of the VPA operator and the VPA: quay.io/joelsmith/vpa-registry:latest It uses the same RBAC as what is checked in to master.

joelsmith commented 4 years ago

/lgtm /approve Thanks for the updates!

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, jwforres

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment