search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Bug 1819025: Update OLM manifests CRD to match CRD in operand repo #13

Closed joelsmith closed 4 years ago

rphillips commented 4 years ago

/lgtm

joelsmith commented 4 years ago

/bugzilla refresh /hold Holding since we don't want this to merge until upstream CRD updates merge (see https://github.com/kubernetes/autoscaler/pull/3080) @rphillips could you please re-review now that I've added the annotations?

openshift-ci-robot commented 4 years ago

@joelsmith: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/13#issuecomment-619275737): >/bugzilla refresh >/hold >Holding since we don't want this to merge until upstream CRD updates merge (see https://github.com/kubernetes/autoscaler/pull/3080) >@rphillips could you please re-review now that I've added the annotations? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@joelsmith: This pull request references Bugzilla bug 1819025, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.5.0) matches configured target release for branch (4.5.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/13): >Bug 1819025: Update OLM manifests CRD to match CRD in operand repo Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 4 years ago

Upstream PR merged /hold cancel

rphillips commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot commented 4 years ago

@joelsmith: All pull requests linked via external trackers have merged: openshift/vertical-pod-autoscaler-operator#12, openshift/vertical-pod-autoscaler-operator#13. Bugzilla bug 1819025 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/13): >Bug 1819025: Update OLM manifests CRD to match CRD in operand repo Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.