Closed joelsmith closed 2 years ago
@joelsmith: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh
.
@joelsmith: This pull request references Jira Issue OCPBUGS-2662, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
This change will need to merge before this PR can pass the tests: https://github.com/openshift/vertical-pod-autoscaler-operator/pull/113
Also, /jira refresh
@joelsmith: This pull request references Jira Issue OCPBUGS-2662, which is valid. The bug has been moved to the POST state.
No GitHub users were found matching the public email listed for the QA contact in Jira (weinliu@redhat.com), skipping review request.
/label backport-risk-assessed
/retest
@joelsmith: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh
.
Retaining the bugzilla/valid-bug label as it was manually added.
@joelsmith: This pull request references Jira Issue OCPBUGS-2662, which is valid.
No GitHub users were found matching the public email listed for the QA contact in Jira (weinliu@redhat.com), skipping review request.
/retest
@joelsmith: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: joelsmith, rphillips
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@joelsmith: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-2662 has been moved to the MODIFIED state.
The manifest change only affects a manual build or the builds used for E2E tests. Customer-facing builds use generated manifests and are not affected by this change.
Also, the upstream E2E tests were broken for 4.10 since this fix PR did not merge prior to our upstream rebase for 4.10: https://github.com/kubernetes/autoscaler/pull/4771
So this fix will use the 4.9 code only for the E2E tests (not for anything else).