search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

[release-4.10] OCPBUGS-2662: Fix E2E CI tests by making currentCSV match CSV file #132

Closed joelsmith closed 2 years ago

joelsmith commented 2 years ago

The manifest change only affects a manual build or the builds used for E2E tests. Customer-facing builds use generated manifests and are not affected by this change.

Also, the upstream E2E tests were broken for 4.10 since this fix PR did not merge prior to our upstream rebase for 4.10: https://github.com/kubernetes/autoscaler/pull/4771

So this fix will use the 4.9 code only for the E2E tests (not for anything else).

openshift-ci[bot] commented 2 years ago

@joelsmith: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/132): >[release-4.10] OCPBUGS-2662: Fix E2E CI tests by making currentCSV match CSV file Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 years ago

@joelsmith: This pull request references Jira Issue OCPBUGS-2662, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/132): >The manifest change only affects a manual build or the builds used for E2E tests. Customer-facing builds use generated manifests and are not affected by this change. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 2 years ago

This change will need to merge before this PR can pass the tests: https://github.com/openshift/vertical-pod-autoscaler-operator/pull/113

Also, /jira refresh

openshift-ci-robot commented 2 years ago

@joelsmith: This pull request references Jira Issue OCPBUGS-2662, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.10.z) matches configured target version for branch (4.10.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-2658](https://issues.redhat.com//browse/OCPBUGS-2658) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE)) * dependent [Jira Issue OCPBUGS-2658](https://issues.redhat.com//browse/OCPBUGS-2658) targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weinliu@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/132#issuecomment-1286064494): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 2 years ago

/label backport-risk-assessed

joelsmith commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@joelsmith: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/132): >[release-4.10] OCPBUGS-2662: Fix E2E CI tests by making currentCSV match CSV file Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 years ago

@joelsmith: This pull request references Jira Issue OCPBUGS-2662, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.10.z) matches configured target version for branch (4.10.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-2658](https://issues.redhat.com//browse/OCPBUGS-2658) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE)) * dependent [Jira Issue OCPBUGS-2658](https://issues.redhat.com//browse/OCPBUGS-2658) targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weinliu@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/132): >The manifest change only affects a manual build or the builds used for E2E tests. Customer-facing builds use generated manifests and are not affected by this change. > >Also, the upstream E2E tests were broken for 4.10 since this fix PR did not merge prior to our upstream rebase for 4.10: https://github.com/kubernetes/autoscaler/pull/4771 > >So this fix will use the 4.9 code only for the E2E tests (not for anything else). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/release-4.10/OWNERS)~~ [joelsmith,rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 years ago

@joelsmith: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2662 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/132): >The manifest change only affects a manual build or the builds used for E2E tests. Customer-facing builds use generated manifests and are not affected by this change. > >Also, the upstream E2E tests were broken for 4.10 since this fix PR did not merge prior to our upstream rebase for 4.10: https://github.com/kubernetes/autoscaler/pull/4771 > >So this fix will use the 4.9 code only for the E2E tests (not for anything else). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.