search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Bug 1819479: Only create "SuccessfulUpdate" events when updates are made #14

Closed joelsmith closed 4 years ago

joelsmith commented 4 years ago

Also:

openshift-ci-robot commented 4 years ago

@joelsmith: This pull request references Bugzilla bug 1819479, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.5.0) matches configured target release for branch (4.5.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/14): >Bug 1819479: Only create "SuccessfulUpdate" events when updates are made Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 4 years ago

@rphillips PTAL when you have a sec. Thanks! /assign @rphillips

rphillips commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot commented 4 years ago

@joelsmith: All pull requests linked via external trackers have merged: openshift/vertical-pod-autoscaler-operator#14. Bugzilla bug 1819479 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/14): >Bug 1819479: Only create "SuccessfulUpdate" events when updates are made Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.