search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

OCPNODE-1707: Updates for 4.14 #146

Closed joelsmith closed 1 year ago

joelsmith commented 1 year ago

Update hack/update-vendor.sh script to also handle k8s dep versioning

Updates for 4.14

kube-openapi pin required as @latest was incompatible with k8s.io/*@v0.27.3

openshift-ci-robot commented 1 year ago

@joelsmith: This pull request references OCPNODE-1707 which is a valid jira issue.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/146): >Update hack/update-vendor.sh script to also handle k8s dep versioning > >Updates for 4.14 >* Update deps >* edit (update to 4.14/0.27.3) and run hack/update-vendor.sh >* go get k8s.io/kube-openapi@54b630e78af56d3a939d3e1d1f0d4d18f3093ace && go mod tidy && go mod vendor >* Update code and build to match updated deps >* Update to go 1.20 (go.mod, Dockerfile, images/ci/Dockerfile) >* Rev version from 4.13 -> 4.14: > sed -i 's/4\.13/4\.14/g' $(git grep -l 4\.13 manifests/) images/ci/bundle.Dockerfile hack/manifest-diff-upstream.sh hack/e2e.sh Makefile >* Verify that Dockerfile.rhel7 & .ci-operator.yaml are up to date (they are. Thanks, ART team!) > >kube-openapi pin required as @latest was incompatible with k8s.io/*@v0.27.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 1 year ago

/retest

openshift-ci[bot] commented 1 year ago

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 11 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.14.0-202311211133.p0.geae798e.assembly.stream for distgit vertical-pod-autoscaler-operator. All builds following this will include this PR.