search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Bug 1835886: Fix CRD versions in CSV #15

Closed joelsmith closed 4 years ago

joelsmith commented 4 years ago

The CSV referenced CRD versions that are not served (v1beta1) which results in a failure to install due to an updated OLM check in https://github.com/operator-framework/operator-lifecycle-manager/pull/1416

The old CSV with v1beta1 CRDs was getting this in the CSV status:

  requirementStatus:
  - group: apiextensions.k8s.io
    kind: CustomResourceDefinition
    message: CRD version not served
    name: verticalpodautoscalercheckpoints.autoscaling.k8s.io
    status: NotPresent
    version: v1
  - group: apiextensions.k8s.io
    kind: CustomResourceDefinition
    message: CRD version not served
    name: verticalpodautoscalers.autoscaling.k8s.io
    status: NotPresent
    version: v1

Also, while fixing this, I noticed that all our versions referenced 4.4, so the second commit updates everything to 4.5.

joelsmith commented 4 years ago

/assign @rphillips

joelsmith commented 4 years ago

/cherrypick release-4.5

openshift-cherrypick-robot commented 4 years ago

@joelsmith: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/15#issuecomment-628740909): >/cherrypick release-4.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@joelsmith: This pull request references Bugzilla bug 1835886, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.5.0) matches configured target release for branch (4.5.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/15): >Bug 1835886: Fix CRD versions in CSV Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rphillips commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 years ago

@joelsmith: All pull requests linked via external trackers have merged: openshift/vertical-pod-autoscaler-operator#15. Bugzilla bug 1835886 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/15): >Bug 1835886: Fix CRD versions in CSV Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 4 years ago

@joelsmith: new pull request created: #16

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/15#issuecomment-628740909): >/cherrypick release-4.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.