search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

PODAUTO-77: PODAUTO-78: Allow container spec overrides for operand containers #150

Closed jkyros closed 11 months ago

jkyros commented 11 months ago

This:

openshift-ci-robot commented 11 months ago

@jkyros: This pull request references PODAUTO-77 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/150): > > >This: >- Extends the `VerticalPodAutoscalerController` types + CRD to add a `ContinerOverrides` struct that can be used to override container `Resources` and `Args`, which will let people tune their deployments without having to fight/disable the operator >- Adjusts the operator such that it understands the new CRD fields and considers them when generating pod/container specs >- This project was being maintained with a very old (v0.10.0?) operator-sdk which no longer seems to work in a go 1.20 environment, so this grudgingly adjusts the Makefile to generate deepcopy/menifsts the "new" ( > v1.0.0) operator-sdk way until we can do a proper migration to a newer version of operator-sdk Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 11 months ago

/approve /lgtm

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros, joelsmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 11 months ago

@jkyros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 11 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.15.0-202311300249.p0.g3018329.assembly.stream for distgit vertical-pod-autoscaler-operator. All builds following this will include this PR.