Closed jkyros closed 8 months ago
@jkyros: This pull request references PODAUTO-99 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/test all
/test all
/test e2e-aws-operator
/test e2e-aws-operator
Yep, that's what I was worried about. Just configuring the default namespaces in the new controller-runtime isn't good enough, it looks like maybe we were freeloading off something else in the old behavior. I'll figure it out next week:
E0210 03:20:22.845247 1 status.go:316] Error getting VerticalPodAutoscalerController: unable to get: /default because of unknown namespace for the cache
W0210 03:20:22.845263 1 status.go:226] Operator status degraded: error checking VPA controllers status: unable to get: /default because of unknown namespace for the cache
E0210 03:20:37.844984 1 status.go:316] Error getting VerticalPodAutoscalerController: unable to get: /default because of unknown namespace for the cache
W0210 03:20:37.845001 1 status.go:226] Operator status degraded: error checking VPA controllers status: unable to get: /default because of unknown namespace for the cache
E0210 03:20:52.845005 1 status.go:316] Error getting VerticalPodAutoscalerController: unable to get: /default because of unknown namespace for the cache
W0210 03:20:52.845024 1 status.go:226] Operator status degraded: error checking VPA controllers status: unable to get: /default because of unknown namespace for the cache
E0210 03:21:07.845086 1 status.go:316] Error getting VerticalPodAutoscalerController: unable to get: /default because of unknown namespace for the cache
W0210 03:21:07.845103 1 status.go:226] Operator status degraded: error checking VPA controllers status: unable to get: /default because of unknown namespace for the cache
E0210 03:21:22.845002 1 status.go:316] Error getting VerticalPodAutoscalerController: unable to get: /default because of unknown namespace for the cache
W0210 03:21:22.845024 1 status.go:226] Operator status degraded: error checking VPA controllers status: unable to get: /default because of unknown namespace for the cache
/test e2e-aws-operator
Yeah, it looks like there were a couple spots where we didn't fill the namespace into the namespacedname, and the old cache used to just kind of assume the default namespace because it could only handle one, but the new cache doesn't do that anymore. /test e2e-aws-operator
/test e2e-aws-operator
That might be a flake, but it's entirely possible the upstream test changed:
{ failed [FAILED] timed out waiting for the condition
In [SynchronizedBeforeSuite] at: /tmp/tmp.J4s7R4xkJU/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1/e2e.go:220 @ 02/10/24 09:30:58.864
}
/test e2e-aws-operator
CI is having trouble pulling images today, I gave it a bit, let's try again /test e2e-aws-operator
/test e2e-aws-operator
I don't know what changed in the upstream test, but it is now upset about the 3 masters that aren't schedulable. /test e2e-aws-operator
@jkyros: This pull request references PODAUTO-99 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
/test all
@jkyros: This pull request references PODAUTO-99 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@jkyros: This pull request references PODAUTO-99 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@jkyros: This pull request references PODAUTO-99 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
helps if I actually commit the right vendored deps :smile: /test all
@jkyros: This pull request references PODAUTO-99 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
/test all
/test unit
e2e-aws-olm
and e2e-aws-operator
won't pass until https://github.com/openshift/kubernetes-autoscaler/pull/286 merges
Whew! This one was trickier than the average version update. Thanks for tracking everything down and cleaning up the messes!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jkyros, joelsmith
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD a194962f316ab288e2f114ae138300e939f219cb and 2 for PR HEAD aca250fc5f71ef3e9319a16f0ffb08c9bb51ebf5 in total
/retest
@jkyros: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.16.0-202402210939.p0.g662efe3.assembly.stream.el9 for distgit vertical-pod-autoscaler-operator. All builds following this will include this PR.
Updates for 4.16
sed -i 's/4.15/4.16/g' $(git grep -l 4.15 manifests/) images/ci/bundle.Dockerfile hack/manifest-diff-upstream.sh hack/e2e.sh Makefile
I also had to do some additional one-off surgery:
lib/resourcemerge