search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

OCPBUGS-30566: Add required infra feature labels #156

Closed joelsmith closed 7 months ago

openshift-ci-robot commented 7 months ago

@joelsmith: This pull request references Jira Issue OCPBUGS-30566, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/156): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 7 months ago

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
joelsmith commented 7 months ago

/hold Trying to figure out whether VPA is FIPS compliant or not

joelsmith commented 7 months ago

/hold cancel Tested with https://github.com/openshift/check-payload to show that it passes all our FIPS compliance checks. Tested 4.15 operator and operand images:

$ sudo ./check-payload scan operator --spec brew.registry.redhat.io/openshift4/ose-vertical-pod-autoscaler-rhel9-operator@sha256:3092fef5a23ccbd17f5252466ef03d50f630b618f42741b92c3a613ba0e69c1e
...
---- Successful run
$ sudo ./check-payload scan operator --spec brew.registry.redhat.io/openshift4/ose-vertical-pod-autoscaler-rhel9@sha256:00a33e04bc1418e75b2c9287fcbedfec0e9c8f4a06bb621de55e59678063c6fc
...
---- Successful run
jkyros commented 7 months ago

/lgtm

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros, joelsmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [jkyros,joelsmith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 7 months ago

@joelsmith: Jira Issue OCPBUGS-30566: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30566 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/156): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
joelsmith commented 7 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 7 months ago

@joelsmith: new pull request created: #157

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/156#issuecomment-1992654201): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.16.0-202403122214.p0.g4006a05.assembly.stream.el9 for distgit vertical-pod-autoscaler-operator. All builds following this will include this PR.