Closed maxcao13 closed 3 months ago
@maxcao13: This pull request references PODAUTO-199 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
As discussed on Slack, sed -i 's/4.16/4.17/g' $(git grep -l 4.15 manifests/)
should have been sed -i 's/4.16/4.17/g' $(git grep -l 4.16 manifests/)
Nice work on the controller runtime related updates!
I think maybe it's time to move off of the openshift/origin-release:golang-1.XX
and registry.ci.openshift.org/openshift/release:golang-1.XX
images and use the registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.XX-openshift-4.YY
images since those seem to be updated regularly while the others don't.
Would you mind switching the images in the following files as part of this update?
Makefile
hack/go-fmt.sh
hack/go-lint.sh
hack/go-vet.sh
hack/manifest-diff-upstream.sh
hack/manifest-diff.sh
I was looking at it, should golint
and its scripts + ci yamls still exist? It seems to be deprecated in favour of go vet
and Staticcheck https://github.com/golang/lint
@maxcao13: This pull request references PODAUTO-199 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
@maxcao13: This pull request references PODAUTO-199 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
Seems like registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.22-openshift-4.17
doesn't include jq
and that causes manifest-diff*.sh
scripts to fail.
Updated with new release images.
@maxcao13: This pull request references PODAUTO-199 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
@maxcao13: This pull request references PODAUTO-199 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
Included PODAUTO-202 changes in this PR.
EDIT: Although, I'm not sure if the Dockerfile in images/ci/Dockerfile
is actually being used anywhere. Here's the current config in openshift/release
: https://github.com/openshift/release/blob/17ca3ef1f06212c127e5ea483b9a4d825370aeeb/ci-operator/config/openshift/vertical-pod-autoscaler-operator/openshift-vertical-pod-autoscaler-operator-master.yaml
Does anyone happen to know?
@maxcao13: This pull request references PODAUTO-199 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: joelsmith, maxcao13
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@maxcao13: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: vertical-pod-autoscaler-operator This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.18.0-202407232010.p0.gd0b168e.assembly.stream.el9. All builds following this will include this PR.
Updates for 4.17
hack/update-vendor.sh
registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.22-openshift-4.17
in go-fmt, go-vet, Makefile, etc...sed -i 's/4.16/4.17/g' $(git grep -l 4.16 manifests/) images/ci/bundle.Dockerfile hack/manifest-diff-upstream.sh hack/e2e.sh Makefile
FROM registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.22-openshift-4.17
(images/ci/Dockerfile
,images/operator-registry/Dockerfile.registry.ci
,Dockerfile
,Dockerfile.rhel
)openshift/origin-v4.0
toregistry.ci.openshift.org/ocp/4.17:base-rhel9
Had to update some struct initialization and func arguments because of a
controller-runtime
upgrade to v18.4 from v17.0 https://github.com/kubernetes-sigs/controller-runtime/pull/2783