Closed maxcao13 closed 2 months ago
@maxcao13: This pull request references PODAUTO-89 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
@maxcao13: This pull request references PODAUTO-89 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
Needs some additional fixes that I haven't pushed yet, locally e2e tests look good!
Another commit is just going to be a README update, which can detail some of the testing steps anyone can take to review.
My gitignore
was seriously ignoring vendored directories and I didn't notice... :/
Reherasals have passed here: https://github.com/openshift/release/pull/55425
@maxcao13: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/golint | 86664a44b1ec3f30d11a9e61ca674860818c0df8 | link | true | /test golint |
Full PR test history. Your PR dashboard.
Not really sure why golint
still exists since I replaced it with lint
. I'm gonna assume it's stale since we changed CI in the middle of this PR.
Also, lint
is expected to fail because of that one deprecated function I mentioned earlier. :-) Link to failed test
Also, lint is expected to fail because of that one deprecated function I mentioned earlier. :-) Link to failed test
If we're squeamish about possible consequences from something like e.g. https://github.com/jkyros/vertical-pod-autoscaler-operator/commit/849ad7eebd82ef187f3056dcff0aa276d4af172e to fix the lint deprecation, can we maybe at least tag that line with a TODO
comment and a //nolint: staticcheck
so we don't have to skip the test in the mean time while we fix it?
Tests passed - awesome! Thanks for all your hard work here Max! /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jkyros, maxcao13
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This PR migrates the repo to a modern operator-sdk v1.35 setup from the previous hacked together setup. This was done by first following the steps in this migration guide that John linked: https://sdk.operatorframework.io/docs/building-operators/golang/migration/, and then porting over the old repo's tests and other configuration for backwards compat.
Here's a summary of the list of changes:
pkg/apis
toapi
.deploy
make target,deploy-bundle
target, where you can deploy the operator with OLM, and adeploy-catalog
target where you can deploy aCatalogSource
+OperatorGroup
with the operator contained to see the UI steps that someone may take to create the operator in the OCP console OperatorHubhack/manifest-diff.sh
and its jq helper since we no longer need to sync install manifests with our CSV (operator-sdk does it for us!)update-vendor.sh
to fit the new repohack/go-*.sh
since operator-sdk generated Makefile has these commands alreadyhack/e2e.sh
to include a flag where you can use your own temporary directory to pull vpa tests from (this was because my internet was being bad and I found it annoying to keep cloning 80 MB)config/olm-catalog
directory to contain the yamls that are required for the catalog buildconfig/vpa
directory with various configs which is required for the vpa operand to functionThis will definitely require some additional changes in Prow config and probably in here as well to make that work.
Please let me know if I missed anything :-)