Closed joelsmith closed 1 month ago
@joelsmith: This pull request references Jira Issue OCPBUGS-40934, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
@joelsmith: This pull request references Jira Issue OCPBUGS-40934, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
@joelsmith: This pull request references Jira Issue OCPBUGS-40934. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
@joelsmith: This pull request references Jira Issue OCPBUGS-40934, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
@joelsmith: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/unit | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | true | /test unit |
ci/prow/e2e-aws-olm | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | true | /test e2e-aws-olm |
ci/prow/security | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | false | /test security |
ci/prow/images | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | true | /test images |
ci/prow/manifest-diff | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | true | /test manifest-diff |
ci/prow/govet | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | true | /test govet |
ci/prow/e2e-aws-operator | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | true | /test e2e-aws-operator |
ci/prow/golint | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | true | /test golint |
ci/prow/gofmt | 72bbc2846ba78640abca7410f01879bfc06dc6ae | link | true | /test gofmt |
Full PR test history. Your PR dashboard.
/label cherry-pick-approved
Awesome, yep, ART apparently went all the way to 1.19: https://github.com/openshift/vertical-pod-autoscaler-operator/blob/a4817b7bf9cf63a7634d587cafc5a30dd4940a9f/.ci-operator.yaml#L4
We were building 1.15 with 1.19, building 1.18 with 1.19 is probably better. :smile:
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jkyros, joelsmith
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/jira refresh /label backport-risk-assessed
@joelsmith: This pull request references Jira Issue OCPBUGS-40934, which is valid. The bug has been moved to the POST state.
No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.
The bug has been updated to refer to the pull request using the external bug tracker.
@joelsmith: Jira Issue OCPBUGS-40934: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-40934 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: vertical-pod-autoscaler-operator This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.12.0-202409181500.p0.g8e9643f.assembly.stream.el8. All builds following this will include this PR.
Also update golang to 1.18 for compatibility with golang.org/x/net@v0.23.0. It appears that ART was already building with 1.18, but we were out of sync and still on 1.15 in several places which makes us fail CI tests.