search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

[release-4.12] OCPBUGS-40934: update VPA golang.org/x/net for http rapid reset for CVE-2024-8421 #176

Closed joelsmith closed 1 month ago

joelsmith commented 1 month ago

Also update golang to 1.18 for compatibility with golang.org/x/net@v0.23.0. It appears that ART was already building with 1.18, but we were out of sync and still on 1.15 in several places which makes us fail CI tests.

sed -i 's/1\.15/1.18/g' Dockerfile Dockerfile.rhel7 Makefile go.mod \
    hack/go-fmt.sh hack/go-lint.sh hack/go-vet.sh hack/manifest-diff.sh \
    images/ci/Dockerfile images/operator-registry/Dockerfile.registry.ci 

go get golang.org/x/net@v0.23.0
go mod tidy
go mod vendor
openshift-ci-robot commented 1 month ago

@joelsmith: This pull request references Jira Issue OCPBUGS-40934, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/176): >Also update golang to 1.18 for compatibility with golang.org/x/net@v0.23.0 > >``` >sed -i 's/1\.17/1.18/g' Dockerfile Dockerfile.rhel7 Makefile go.mod \ > hack/go-fmt.sh hack/go-lint.sh hack/go-vet.sh hack/manifest-diff.sh \ > images/ci/Dockerfile images/operator-registry/Dockerfile.registry.ci > >go get golang.org/x/net@v0.23.0 >go mod tidy >go mod vendor >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@joelsmith: This pull request references Jira Issue OCPBUGS-40934, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/176): >Also update golang to 1.18 for compatibility with golang.org/x/net@v0.23.0 > >``` >sed -i 's/1\.15/1.18/g' Dockerfile Dockerfile.rhel7 Makefile go.mod \ > hack/go-fmt.sh hack/go-lint.sh hack/go-vet.sh hack/manifest-diff.sh \ > images/ci/Dockerfile images/operator-registry/Dockerfile.registry.ci > >go get golang.org/x/net@v0.23.0 >go mod tidy >go mod vendor >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@joelsmith: This pull request references Jira Issue OCPBUGS-40934. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/176): >Also update golang to 1.18 for compatibility with golang.org/x/net@v0.23.0. It appears that ART was already building with 1.18, but we were out of sync and still on 1.15 in several places which makes us fail CI tests. > >``` >sed -i 's/1\.15/1.18/g' Dockerfile Dockerfile.rhel7 Makefile go.mod \ > hack/go-fmt.sh hack/go-lint.sh hack/go-vet.sh hack/manifest-diff.sh \ > images/ci/Dockerfile images/operator-registry/Dockerfile.registry.ci > >go get golang.org/x/net@v0.23.0 >go mod tidy >go mod vendor >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@joelsmith: This pull request references Jira Issue OCPBUGS-40934, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/176): >Also update golang to 1.18 for compatibility with golang.org/x/net@v0.23.0. It appears that ART was already building with 1.18, but we were out of sync and still on 1.15 in several places which makes us fail CI tests. > >``` >sed -i 's/1\.15/1.18/g' Dockerfile Dockerfile.rhel7 Makefile go.mod \ > hack/go-fmt.sh hack/go-lint.sh hack/go-vet.sh hack/manifest-diff.sh \ > images/ci/Dockerfile images/operator-registry/Dockerfile.registry.ci > >go get golang.org/x/net@v0.23.0 >go mod tidy >go mod vendor >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@joelsmith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 72bbc2846ba78640abca7410f01879bfc06dc6ae link true /test unit
ci/prow/e2e-aws-olm 72bbc2846ba78640abca7410f01879bfc06dc6ae link true /test e2e-aws-olm
ci/prow/security 72bbc2846ba78640abca7410f01879bfc06dc6ae link false /test security
ci/prow/images 72bbc2846ba78640abca7410f01879bfc06dc6ae link true /test images
ci/prow/manifest-diff 72bbc2846ba78640abca7410f01879bfc06dc6ae link true /test manifest-diff
ci/prow/govet 72bbc2846ba78640abca7410f01879bfc06dc6ae link true /test govet
ci/prow/e2e-aws-operator 72bbc2846ba78640abca7410f01879bfc06dc6ae link true /test e2e-aws-operator
ci/prow/golint 72bbc2846ba78640abca7410f01879bfc06dc6ae link true /test golint
ci/prow/gofmt 72bbc2846ba78640abca7410f01879bfc06dc6ae link true /test gofmt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
asahay19 commented 1 month ago

/label cherry-pick-approved

jkyros commented 1 month ago

Awesome, yep, ART apparently went all the way to 1.19: https://github.com/openshift/vertical-pod-autoscaler-operator/blob/a4817b7bf9cf63a7634d587cafc5a30dd4940a9f/.ci-operator.yaml#L4

We were building 1.15 with 1.19, building 1.18 with 1.19 is probably better. :smile:

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros, joelsmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/release-4.12/OWNERS)~~ [joelsmith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
joelsmith commented 1 month ago

/jira refresh /label backport-risk-assessed

openshift-ci-robot commented 1 month ago

@joelsmith: This pull request references Jira Issue OCPBUGS-40934, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-40935](https://issues.redhat.com//browse/OCPBUGS-40935) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-40935](https://issues.redhat.com//browse/OCPBUGS-40935) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/176#issuecomment-2358660277): >/jira refresh >/label backport-risk-assessed Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@joelsmith: Jira Issue OCPBUGS-40934: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-40934 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/176): >Also update golang to 1.18 for compatibility with golang.org/x/net@v0.23.0. It appears that ART was already building with 1.18, but we were out of sync and still on 1.15 in several places which makes us fail CI tests. > >``` >sed -i 's/1\.15/1.18/g' Dockerfile Dockerfile.rhel7 Makefile go.mod \ > hack/go-fmt.sh hack/go-lint.sh hack/go-vet.sh hack/manifest-diff.sh \ > images/ci/Dockerfile images/operator-registry/Dockerfile.registry.ci > >go get golang.org/x/net@v0.23.0 >go mod tidy >go mod vendor >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: vertical-pod-autoscaler-operator This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.12.0-202409181500.p0.g8e9643f.assembly.stream.el8. All builds following this will include this PR.