Open maxcao13 opened 1 week ago
@maxcao13: This pull request references PODAUTO-250 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: maxcao13 Once this PR has been reviewed and has the lgtm label, please assign jkyros for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@maxcao13: all tests passed!
Full PR test history. Your PR dashboard.
Updates defaults according to vpa benchmarking spike/new documentation defaults.
I was thinking of not setting CPU limits for the operator, but since we should ideally set memory limits at least, I added additional CPU limits to the main container (alongisde the kube-rbac-proxy container limits), in case something really goes wrong somehow, we do not use more CPU than intended (and all the operator is doing is reconciling anyways).