search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

PODAUTO-250: Update default resource requests and QPS/Burst #178

Open maxcao13 opened 1 week ago

maxcao13 commented 1 week ago

Updates defaults according to vpa benchmarking spike/new documentation defaults.

I was thinking of not setting CPU limits for the operator, but since we should ideally set memory limits at least, I added additional CPU limits to the main container (alongisde the kube-rbac-proxy container limits), in case something really goes wrong somehow, we do not use more CPU than intended (and all the operator is doing is reconciling anyways).

openshift-ci-robot commented 1 week ago

@maxcao13: This pull request references PODAUTO-250 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/178): >Updates defaults according to vpa benchmarking spike/new documentation defaults. > >I was thinking of not setting CPU limits for the operator, but since we [_should ideally_](https://sdk.operatorframework.io/docs/best-practices/managing-resources/#managing-resources) set memory limits at least, I added additional CPU limits to the main container (alongisde the kube-rbac-proxy container limits), in case something _really_ goes wrong somehow, we do not use more CPU than intended (and all the operator is doing is reconciling anyways). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvertical-pod-autoscaler-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maxcao13 Once this PR has been reviewed and has the lgtm label, please assign jkyros for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 week ago

@maxcao13: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).