search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Add required CSV fields, update VPA CR example, add VPA Controller CR example #25

Closed joelsmith closed 4 years ago

joelsmith commented 4 years ago

The last image build failed the metadation validation step. See http://external-ci-coldstorage.datahub.redhat.com/cvp/cvp-redhat-operator-metadata-validation-test/ose-vertical-pod-autoscaler-operator-metadata-container-v4.5.0.202006031723.dev-1/ca074d41-4ded-4a5f-912a-1bfaaf6188c7/operator-metadata-linting-output.txt

This PR adds the required and recommended fields.

To validate the manifests, I did:

$ pip3 install operator-courier
$ operator-courier verify --ui_validate_io manifests/

which is what the metadata import process does as part of its tests.

rphillips commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment