search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Bug 1853072: Update version check for .p? suffix #30

Closed yselkowitz closed 4 years ago

openshift-ci-robot commented 4 years ago

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 4 years ago

/cherrypick release-4.5 /ok-to-test /lgtm /approve

openshift-cherrypick-robot commented 4 years ago

@joelsmith: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/30#issuecomment-652643935): >/cherrypick release-4.5 >/ok-to-test >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 years ago

@yselkowitz: This pull request references Bugzilla bug 1853072, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.6.0) matches configured target release for branch (4.6.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/30): >Bug 1853072: Update version check for .p? suffix Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 4 years ago

Test seems to be broken. Manually verified. /override ci/prow/e2e-aws

openshift-ci-robot commented 4 years ago

@joelsmith: Overrode contexts on behalf of joelsmith: ci/prow/e2e-aws

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/30#issuecomment-653025626): >Test seems to be broken. Manually verified. >/override ci/prow/e2e-aws Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@yselkowitz: All pull requests linked via external trackers have merged: openshift/vertical-pod-autoscaler-operator#30. Bugzilla bug 1853072 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/30): >Bug 1853072: Update version check for .p? suffix Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 4 years ago

@joelsmith: new pull request created: #31

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/30#issuecomment-652643935): >/cherrypick release-4.5 >/ok-to-test >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.