openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

[release-4.5] Bug 1853371: Update version check for .p? suffix #31

Closed openshift-cherrypick-robot closed 4 years ago

openshift-cherrypick-robot commented 4 years ago

This is an automated cherry-pick of #30

/assign joelsmith

openshift-ci-robot commented 4 years ago

@openshift-cherrypick-robot: Bugzilla bug 1853072 has been cloned as Bugzilla bug 1853371. Retitling PR to link against new bug. /retitle [release-4.5] Bug 1853371: Update version check for .p? suffix

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/31): >[release-4.5] Bug 1853072: Update version check for .p? suffix Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1853371, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.5.0) matches configured target release for branch (4.5.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 1853072](https://bugzilla.redhat.com/show_bug.cgi?id=1853072) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Bugzilla bug 1853072](https://bugzilla.redhat.com/show_bug.cgi?id=1853072) targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z * bug has dependents
In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/31): >[release-4.5] Bug 1853371: Update version check for .p? suffix Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 4 years ago

/lgtm /approve

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/release-4.5/OWNERS)~~ [joelsmith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sdodson commented 4 years ago

This avoids an ART build time problem and has been advocated by that team as well, so cherry-pick-approved

yselkowitz commented 4 years ago

/retest

openshift-ci-robot commented 4 years ago

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/vertical-pod-autoscaler-operator#31. Bugzilla bug 1853371 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/31): >[release-4.5] Bug 1853371: Update version check for .p? suffix Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.