search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

bug 1886200: manifests/art.yaml: CSV name is verticalpodautoscaler #39

Closed sosiouxme closed 4 years ago

sosiouxme commented 4 years ago

Having successfully pushed to stage once, tests began failing, revealing that the CSV name replacement that was supposed to happen to give it a unique name for each build - wasn't matching. So it gets the same name every time which fails the test. This should make the match work. This is required to ship.

4.6 PR is https://github.com/openshift/vertical-pod-autoscaler-operator/pull/38

openshift-ci-robot commented 4 years ago

@sosiouxme: This pull request references Bugzilla bug 1886200, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/39): >bug 1886200: manifests/art.yaml: CSV name is verticalpodautoscaler Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sosiouxme commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@sosiouxme: This pull request references Bugzilla bug 1886200, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.7.0) matches configured target release for branch (4.7.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/39#issuecomment-705208040): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@sosiouxme: This pull request references Bugzilla bug 1886200, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.7.0) matches configured target release for branch (4.7.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/39): >bug 1886200: manifests/art.yaml: CSV name is verticalpodautoscaler Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 4 years ago

/lgtm /approve /retest

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot commented 4 years ago

@sosiouxme: All pull requests linked via external trackers have merged:

Bugzilla bug 1886200 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/39): >bug 1886200: manifests/art.yaml: CSV name is verticalpodautoscaler Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.