search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Bring manual install RBAC in line with CSV RBAC #53

Closed joelsmith closed 3 years ago

joelsmith commented 3 years ago

/retest

wangchen615 commented 3 years ago

/approve

joelsmith commented 3 years ago

I think that the e2e-aws test is flaky right now. /retest

wangchen615 commented 3 years ago

/lgtm

joelsmith commented 3 years ago

/hold Holding to make sure that #56 merges first (without retesting).

Also, looks like we'll need to investigate why the above /lgtm didn't add the label even though we have added @wangchen615 to the OWNERS file in #52. Maybe there is a delay between the file update and the bot being updated with new approvers or reviewers.

rphillips commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,rphillips,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
joelsmith commented 3 years ago

/hold cancel