search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Sync OLM CRDs to manual-install CRDs #57

Closed joelsmith closed 3 years ago

joelsmith commented 3 years ago

Also split install/06_vpacheckpoint-crd.yaml out of install/05_vpa-crd.yaml

joelsmith commented 3 years ago

@wangchen615 sure enough, the manual-install CRDs were out of date. I'll be opening another PR which adds a check to make sure that they stay updated in the future so that we don't waste our time using outdated versions of the CRDs or RBAC.

joelsmith commented 3 years ago

/retest

wangchen615 commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment