search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

add Makefile target e2e-olm-local e2e-local e2e-olm-ci e2e-ci to automate the olm installation and the upstream e2e testing #60

Closed wangchen615 closed 3 years ago

wangchen615 commented 3 years ago
  1. Added dev-image, dev-push targets in Makefile to allow dev image build.
  2. Add deploy-olm-local, deploy-olm-ci, deploy to deploy the operator in local mode, in ci mode, and in non-olm mode. Correspondingly, artifacts and images are added for various deployment options.
  3. Updated hack/e2e.sh to add the upstream e2e testing for the operator.
  4. Automate the e2e testing in e2e-olm-local and e2e-local targets.

Resolve and close #59

rphillips commented 3 years ago

Let's squash the PR and then I'll lgtm

joelsmith commented 3 years ago

@wangchen615 I think we're ready to merge this, but would you please rebase to the current master and squash the commits first?

edit: @rphillips beat me to it! :smile:

wangchen615 commented 3 years ago

@wangchen615 I think we're ready to merge this, but would you please rebase to the current master and squash the commits first?

edit: @rphillips beat me to it! 😄

@rphillips @joelsmith the commits are squashed. Thanks.

rphillips commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,rphillips,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rphillips commented 3 years ago

Thank you again. :)