search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Add build target to e2e-ci targets. #71

Closed wangchen615 closed 3 years ago

wangchen615 commented 3 years ago

Add build to CI targets.

wangchen615 commented 3 years ago

/assign @joelsmith

rphillips commented 3 years ago

/lgtm /test e2e-aws

joelsmith commented 3 years ago

/hold

Would it be better to have a default NO_DOCKER value of 0 then do make <target> NO_DOCKER=1 when running CI tests?

joelsmith commented 3 years ago

/lgtm /hold cancel

joelsmith commented 3 years ago

Thanks! /lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,rphillips,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
joelsmith commented 3 years ago

/retest

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

wangchen615 commented 3 years ago

/retest

joelsmith commented 3 years ago

Now that the e2e-aws test has been removed, let's try closing and re-opening this PR to see if that change will take effect.

/close

openshift-ci-robot commented 3 years ago

@joelsmith: Closed this PR.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/71#issuecomment-815216399): >Now that the e2e-aws test has been removed, let's try closing and re-opening this PR to see if that change will take effect. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 3 years ago

Reopening. Hopefully the new CI config will be in effect.

openshift-ci[bot] commented 3 years ago

@wangchen615: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 5ff01fdec6911e45a42468439275c80e8522f69c link /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).