search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Pass oc to e2e.sh script for CI tests #80

Closed wangchen615 closed 3 years ago

wangchen615 commented 3 years ago
  1. The e2e.sh should use ${KUBECTL} as an input variable instead of using kubectl for all CI tests.
  2. The e2e-ci target deploy operator and controllers directly and do not need to deploy $(CONFIGMAP_ENV_FILE). Removing the configmap_env_file for registry before the deployment.
rphillips commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [rphillips,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment