search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Update Makefile #85

Closed wangchen615 closed 3 years ago

wangchen615 commented 3 years ago

Change dev operator and operand image names to be consistent with the CI images used.

rphillips commented 3 years ago

hmm. would this change impact upgrades by changing the name?

joelsmith commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wangchen615 commented 3 years ago

hmm. would this change impact upgrades by changing the name?

No impact on upgrades. This will only change the local build, which will not impact any CI tests. Changing it just to make it look consistent.