search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Bug 1950210: Update CRD API version to match upstream and cleanup for yamllint #89

Closed joelsmith closed 3 years ago

joelsmith commented 3 years ago

The CRD API version v1beta1 is being deprecated, so we must update all CRDs to v1.

joelsmith commented 3 years ago

This PR has two purposes. In addition to updating the CRD from the deprecated v1beta1 version to v1, I expect this PR to fail the new manifest-diff test. Once I see that the test is properly working, I will make the same changes to the install/deploy versions of the CRDs.

Edit: it did fail the test as hoped. Updated commit pushed to bring the two versions into sync.

joelsmith commented 3 years ago

/retest

openshift-ci-robot commented 3 years ago

@joelsmith: This pull request references Bugzilla bug 1950210, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.8.0) matches configured target release for branch (4.8.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weinliu@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/89): >Bug 1950210: Update CRD API version to match upstream and cleanup for yamllint Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 3 years ago

@wangchen615 could you please review? I used this to update the upstream object CRDs:

https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/deploy/vpa-v1-crd-gen.yaml

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 years ago

@joelsmith: All pull requests linked via external trackers have merged:

Bugzilla bug 1950210 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/89): >Bug 1950210: Update CRD API version to match upstream and cleanup for yamllint Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.