Closed joelsmith closed 3 years ago
This PR has two purposes. In addition to updating the CRD from the deprecated v1beta1 version to v1, I expect this PR to fail the new manifest-diff
test. Once I see that the test is properly working, I will make the same changes to the install/deploy
versions of the CRDs.
Edit: it did fail the test as hoped. Updated commit pushed to bring the two versions into sync.
/retest
@joelsmith: This pull request references Bugzilla bug 1950210, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weinliu@redhat.com), skipping review request.
@wangchen615 could you please review? I used this to update the upstream object CRDs:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: joelsmith, wangchen615
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@joelsmith: All pull requests linked via external trackers have merged:
Bugzilla bug 1950210 has been moved to the MODIFIED state.
The CRD API version v1beta1 is being deprecated, so we must update all CRDs to v1.