search

openshift / vertical-pod-autoscaler-operator

An Operator for running the Vertical Pod Autoscaler on OpenShift
Apache License 2.0
27 stars 30 forks source link

Bug 1974567: Remove unneeded run-level from namespace in manual install manifests #97

Closed joelsmith closed 3 years ago

joelsmith commented 3 years ago

According to https://bugzilla.redhat.com/show_bug.cgi?id=1805488, only components which must run before the SCC controller starts should use run-level 1. VPA is fine to run with the restricted SCC.

openshift-ci[bot] commented 3 years ago

@joelsmith: This pull request references Bugzilla bug 1974567, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/97): >Bug 1974567: Remove unneeded run-level from namespace in manual install manifests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@joelsmith: This pull request references Bugzilla bug 1974567, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.0) matches configured target release for branch (4.9.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/97#issuecomment-866085744): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 years ago

@joelsmith: This pull request references Bugzilla bug 1974567, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.0) matches configured target release for branch (4.9.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/97): >Bug 1974567: Remove unneeded run-level from namespace in manual install manifests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joelsmith commented 3 years ago

Chen, could you please take a look? /assign @wangchen615

joelsmith commented 3 years ago

/retest

wangchen615 commented 3 years ago

Chen, could you please take a look? /assign @wangchen615

@joelsmith I see the log says the below:

Current deployments and pods:
NAME                               READY   UP-TO-DATE   AVAILABLE   AGE
vertical-pod-autoscaler-operator   0/1     0            0           4m38s
No resources found in openshift-vertical-pod-autoscaler namespace.

I need to test it again on my local env to see what is the error for the not-ready deployment.

joelsmith commented 3 years ago

/retest

wangchen615 commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, wangchen615

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith,wangchen615] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 years ago

@joelsmith: All pull requests linked via external trackers have merged:

Bugzilla bug 1974567 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/97): >Bug 1974567: Remove unneeded run-level from namespace in manual install manifests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.