Bug 1987136: Declare supported arches in CSV

yselkowitz commented 3 years ago

The OperatorHub currently assumes x86-only for any operators which do not declare any such labels. Declaring these explicitly should make the current status more obvious in the code, and make it easier to correctly add further architectures when conditions warrant.

openshift-ci[bot] commented 3 years ago

@yselkowitz: This pull request references Bugzilla bug 1987136, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target release (4.9.0) matches configured target release for branch (4.9.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @jianzhangbjz

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/99): >Bug 1987136: Declare supported arches in CSV Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

yselkowitz commented 3 years ago

/assign @sjenning

yselkowitz commented 3 years ago

/test all /assign @joelsmith

yselkowitz commented 3 years ago

failure is unrelated /retest

yselkowitz commented 3 years ago

No way this is related:

FAIL: Unexpected error:
    <*errors.errorString | 0xc0005a82f0>: {
        s: "error waiting for memory request in range of ({{1468006400 0} {<nil>}  BinarySI},{{10485760000 0} {<nil>}  BinarySI}) for pods: {TypeMeta:{Kind: APIVersion:} LabelSelector:name=hamster FieldSelector:status.phase!=Failed,status.phase!=Succeeded Watch:false AllowWatchBookmarks:false ResourceVersion: TimeoutSeconds:<nil> Limit:0 Continue:}",
    }
    error waiting for memory request in range of ({{1468006400 0} {<nil>}  BinarySI},{{10485760000 0} {<nil>}  BinarySI}) for pods: {TypeMeta:{Kind: APIVersion:} LabelSelector:name=hamster FieldSelector:status.phase!=Failed,status.phase!=Succeeded Watch:false AllowWatchBookmarks:false ResourceVersion: TimeoutSeconds:<nil> Limit:0 Continue:}
occurred

Full Stack Trace
command-line-arguments.glob..func8.2()
    /tmp/tmp.UMn2hkVd3F/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1/full_vpa.go:168 +0x306
command-line-arguments.RunE2ETests(0xc000457080)
    /tmp/tmp.UMn2hkVd3F/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1/e2e.go:121 +0x329
command-line-arguments.TestE2E(0xc000457080)
    /tmp/tmp.UMn2hkVd3F/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1/e2e_test.go:83 +0x2b
testing.tRunner(0xc000457080, 0x2abb380)
    /usr/local/go/src/testing/testing.go:1123 +0xef
created by testing.(*T).Run
    /usr/local/go/src/testing/testing.go:1168 +0x2b3

joelsmith commented 3 years ago

/lgtm /approve Thanks!

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/OWNERS)~~ [joelsmith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

yselkowitz commented 3 years ago

Is that test failure a known issue? For this to get in, either that needs to get fixed, or we'll need an override.

yselkowitz commented 3 years ago

/retest-required

openshift-ci[bot] commented 3 years ago

@yselkowitz: Some pull requests linked via external trackers have merged:

openshift/cluster-kube-descheduler-operator#206

The following pull requests linked via external trackers have not merged:

openshift/cluster-resource-override-admission-operator#68 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1987136 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vertical-pod-autoscaler-operator/pull/99): >Bug 1987136: Declare supported arches in CSV Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift / vertical-pod-autoscaler-operator

Bug 1987136: Declare supported arches in CSV #99