Closed yselkowitz closed 3 years ago
@yselkowitz: This pull request references Bugzilla bug 1987136, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.
Requesting review from QA contact: /cc @jianzhangbjz
/assign @sjenning
/test all /assign @joelsmith
failure is unrelated /retest
No way this is related:
FAIL: Unexpected error:
<*errors.errorString | 0xc0005a82f0>: {
s: "error waiting for memory request in range of ({{1468006400 0} {<nil>} BinarySI},{{10485760000 0} {<nil>} BinarySI}) for pods: {TypeMeta:{Kind: APIVersion:} LabelSelector:name=hamster FieldSelector:status.phase!=Failed,status.phase!=Succeeded Watch:false AllowWatchBookmarks:false ResourceVersion: TimeoutSeconds:<nil> Limit:0 Continue:}",
}
error waiting for memory request in range of ({{1468006400 0} {<nil>} BinarySI},{{10485760000 0} {<nil>} BinarySI}) for pods: {TypeMeta:{Kind: APIVersion:} LabelSelector:name=hamster FieldSelector:status.phase!=Failed,status.phase!=Succeeded Watch:false AllowWatchBookmarks:false ResourceVersion: TimeoutSeconds:<nil> Limit:0 Continue:}
occurred
Full Stack Trace
command-line-arguments.glob..func8.2()
/tmp/tmp.UMn2hkVd3F/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1/full_vpa.go:168 +0x306
command-line-arguments.RunE2ETests(0xc000457080)
/tmp/tmp.UMn2hkVd3F/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1/e2e.go:121 +0x329
command-line-arguments.TestE2E(0xc000457080)
/tmp/tmp.UMn2hkVd3F/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1/e2e_test.go:83 +0x2b
testing.tRunner(0xc000457080, 0x2abb380)
/usr/local/go/src/testing/testing.go:1123 +0xef
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:1168 +0x2b3
/lgtm /approve Thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: joelsmith, yselkowitz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Is that test failure a known issue? For this to get in, either that needs to get fixed, or we'll need an override.
/retest-required
@yselkowitz: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh
.
Bugzilla bug 1987136 has not been moved to the MODIFIED state.
The OperatorHub currently assumes x86-only for any operators which do not declare any such labels. Declaring these explicitly should make the current status more obvious in the code, and make it easier to correctly add further architectures when conditions warrant.