search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

OCPBUGS-14829: Warn usernames without domain name #121

Closed gnufied closed 1 year ago

gnufied commented 1 year ago

Fixes https://issues.redhat.com/browse/OCPBUGS-14829

We could emit a metric here as well, and create alerts but I am worried about customers then complaining about noisy alerts.

openshift-ci-robot commented 1 year ago

@gnufied: This pull request references Jira Issue OCPBUGS-14829, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/121): >Fixes https://issues.redhat.com/browse/OCPBUGS-14829 > >We could emit a metric here as well, and create alerts but I am worried about customers then complaining about noisy alerts. > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [gnufied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

jsafrane commented 1 year ago

/retest-required /lgtm

openshift-ci[bot] commented 1 year ago

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-csi-extended 4e60e7e66589b511da52e0434d3aad8ff482193c link false /test e2e-vsphere-csi-extended
ci/prow/e2e-vsphere-zones 4e60e7e66589b511da52e0434d3aad8ff482193c link false /test e2e-vsphere-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD c5118c340b2683046fe5e24439395ca75709eebb and 2 for PR HEAD 4e60e7e66589b511da52e0434d3aad8ff482193c in total

openshift-ci-robot commented 1 year ago

@gnufied: Jira Issue OCPBUGS-14829: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14829 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/121): >Fixes https://issues.redhat.com/browse/OCPBUGS-14829 > >We could emit a metric here as well, and create alerts but I am worried about customers then complaining about noisy alerts. > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 1 year ago

/cherry-pick release-4.14 /cherry-pick release-4.13 /cherry-pick release-4.12

openshift-cherrypick-robot commented 1 year ago

@gnufied: new pull request created: #134

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/121#issuecomment-1766469165): >/cherry-pick release-4.14 >/cherry-pick release-4.13 >/cherry-pick release-4.12 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.