search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

OCPBUGS-14177: Add a cache datacenters and datastores #123

Closed jsafrane closed 1 year ago

jsafrane commented 1 year ago

The cache is fresh for each check run. It caches all datacenters that any check loaded + all their datastores, even though not all of them may be used by the checks.

I still need to figure our how to unit-test this.

@openshift/storage

openshift-ci-robot commented 1 year ago

@jsafrane: This pull request references Jira Issue OCPBUGS-14177, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/123): >The cache is fresh for each check run. It caches all datacenters that any check loaded + all their datastores, even though not all of them may be used by the checks. > >I still need to figure our how to unit-test this. > >@openshift/storage Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsafrane commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@jsafrane: This pull request references Jira Issue OCPBUGS-14177, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/123#issuecomment-1647969007): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 1 year ago

We are about to add support for multiple vCenters in OCP. Should we update this PR to be somewhat future proof? Such as - another datacenter with same name can exist in different vcenter etc.

jsafrane commented 1 year ago

Do we know how multiple vCenter support would look like? Would we have multiple clients? I can make it more future proof, but I need to know how the API should look like:

jsafrane commented 1 year ago

There is a risk that I design something that will need refactoring, because I get the API wrong.

openshift-ci[bot] commented 1 year ago

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-csi-extended e92669d220be470b7318ee1bb544980661390061 link false /test e2e-vsphere-csi-extended
ci/prow/e2e-vsphere-zones e92669d220be470b7318ee1bb544980661390061 link false /test e2e-vsphere-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
gnufied commented 1 year ago

/lgtm

openshift-ci-robot commented 1 year ago

@jsafrane: Jira Issue OCPBUGS-14177: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14177 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/123): >The cache is fresh for each check run. It caches all datacenters that any check loaded + all their datastores, even though not all of them may be used by the checks. > >I still need to figure our how to unit-test this. > >@openshift/storage Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.