OCPBUGS-7413: Use collector for ephemeral metrics

[gnufied]

This change frees up individual check from storing the metrics that can change and need not be emitted anymore.

Fixes OCPBUGS-7413

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [gnufied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[gnufied]

/hold

[gnufied]

/hold cancel

[jsafrane]

CI failure could be related: [vSphere-Problem-Detector] should check the vsphere version and report in metric for alerter raising by CSO

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_vsphere-problem-detector/125/pull-ci-openshift-vsphere-problem-detector-master-e2e-vsphere-csi-extended/1701980713378648064

[jsafrane]

(lgtm otherwise)

[jsafrane]

/retest

[openshift-ci[bot]]

@gnufied: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-csi-extended	7313f8728c6d82872a27d7a27e8d98b6b4aef4de	link	false	/test e2e-vsphere-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[gnufied]

@Phaow @duanwei33 Can you help out with those extended tests and why they are failing? I tested after this change and I can see both vcenter and esxi metrics present as expected.

[gnufied]

I feel like this job has a problem on 4.15 because:

        ocSupportVsVersion := map[string]string{
            "4.12": "7.0.2",
            "4.13": "7.0.2",
            "4.14": "7.0.2",
        }

So there is no version mapping for 4.15 yet. I am not sure how it will pass in 4.15 environment.

[Phaow]

Hi @gnufied , good catch, correct the ocSupportVsVersion map missed the latest 4.15, sorry for the noise, I fixed it in https://github.com/openshift/openshift-tests-private/pull/11949 . We could ignore it firstly, the fix will maybe merge a bit later(After team back to review). BTW, for the 4.15 plan we still support vSphere 7.0.2+, right?

[jsafrane]

/lgtm

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-7413, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/125): >This change frees up individual check from storing the metrics that can change and need not be emitted anymore. > > >Fixes OCPBUGS-7413 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[gnufied]

/jira refresh

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-7413, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/125#issuecomment-1766766145): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[openshift-ci-robot]

@gnufied: Jira Issue OCPBUGS-7413: Some pull requests linked via external trackers have merged:

• openshift/vsphere-problem-detector#125

The following pull requests linked via external trackers have not merged:

• openshift/vsphere-problem-detector#135 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-7413 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/125): >This change frees up individual check from storing the metrics that can change and need not be emitted anymore. > > >Fixes OCPBUGS-7413 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.