[release-4.14] OCPBUGS-21812: Warn usernames without domain name

[openshift-cherrypick-robot]

This is an automated cherry-pick of #121

/assign gnufied

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-14829 has been cloned as Jira Issue OCPBUGS-21812. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-21812: Warn usernames without domain name

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/134): >This is an automated cherry-pick of #121 > >/assign gnufied Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21812, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-14829](https://issues.redhat.com//browse/OCPBUGS-14829) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-14829](https://issues.redhat.com//browse/OCPBUGS-14829) targets the "4.15.0" version, which is one of the valid target versions: 4.15.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/134): >This is an automated cherry-pick of #121 > >/assign gnufied Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[jsafrane]

/lgtm /approve /label backport-risk-assessed

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/release-4.14/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[duanwei33]

Pre-verified with open PR:

$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.14.0-0.test-2024-01-04-111650-ci-ln-7yb5n4k-latest   True        False         3m30s   Cluster version is 4.14.0-0.test-2024-01-04-111650-ci-ln-7yb5n4k-latest

$ oc -n openshift-cluster-storage-operator logs vsphere-problem-detector-operator-76d8f9f9b5-85z9l | grep "full domain name"
W0104 13:22:17.048663       1 vsphere_check.go:132] vCenter username for ocp-storage.vmc.qe.devcluster.openshift.com is without domain, please consider using username with full domain name

[duanwei33]

/label qe-approved

[duanwei33]

/label cherry-pick-approved

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21812, which is valid.

6 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-14829](https://issues.redhat.com//browse/OCPBUGS-14829) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-14829](https://issues.redhat.com//browse/OCPBUGS-14829) targets the "4.15.0" version, which is one of the valid target versions: 4.15.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/134): >This is an automated cherry-pick of #121 > >/assign gnufied Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD db5e66c6ff913207b2286db21c3da9d440fb0be9 and 2 for PR HEAD 6fe7cf56880748ebf5de63ffa0fb0909893cdd9d in total

[jsafrane]

/retest-required

[jsafrane]

/retest-required

[openshift-ci[bot]]

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-csi-extended	6fe7cf56880748ebf5de63ffa0fb0909893cdd9d	link	false	/test e2e-vsphere-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[duanwei33]

/test e2e-vsphere

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21812: All pull requests linked via external trackers have merged:

• openshift/vsphere-problem-detector#134

Jira Issue OCPBUGS-21812 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/134): >This is an automated cherry-pick of #121 > >/assign gnufied Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vsphere-problem-detector-container-v4.14.0-202401291010.p0.g4826882.assembly.stream for distgit vsphere-problem-detector. All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2024-01-30-095544