search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

SPLAT-1658: Add multi vCenter support #158

Closed vr4manta closed 3 months ago

vr4manta commented 5 months ago

SPLAT-1658

Changes

openshift-ci-robot commented 5 months ago

@vr4manta: This pull request references SPLAT-1658 which is a valid jira issue.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/158): >[SPLAT-1658](https://issues.redhat.com/browse/SPLAT-1658) > >### Changes >- Added support for YAML config files >- Enhanced logic to handle multiple vCenters for various checks >- Updated unit tests > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

vr4manta commented 5 months ago

/test all

vr4manta commented 5 months ago

/test all

vr4manta commented 5 months ago

/test all

vr4manta commented 5 months ago

/retest-required

openshift-ci-robot commented 5 months ago

@vr4manta: This pull request references SPLAT-1658 which is a valid jira issue.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/158): >[SPLAT-1658](https://issues.redhat.com/browse/SPLAT-1658) > >### Changes >- Added support for YAML config files >- Enhanced logic to handle multiple vCenters for various checks >- Created new checker to verify infrastructure config and cloud provider config >- Updated unit tests > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vr4manta commented 4 months ago

/retest-required

jsafrane commented 4 months ago

/lgtm /label px-approved /label docs-approved

I am not adding approval, I want to test it. Let's try CI first: /payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-upi-zones

openshift-ci[bot] commented 4 months ago

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d76b63e0-3f8e-11ef-8f6e-8a9b9e196ea2-0

vr4manta commented 4 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-techpreview openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/installer#8638 Running this one to include the installer changes to get YAML config introduced.

openshift-ci[bot] commented 4 months ago

@vr4manta: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. unable to get additional pr info from string: this: string: this doesn't match expected format: org/repo#number

Please contact an administrator to resolve this issue.

openshift-ci[bot] commented 4 months ago

@vr4manta: This PR was included in a payload test run from openshift/installer#8638 trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci[bot] commented 4 months ago

@vr4manta: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. unable to get additional pr info from string: one: string: one doesn't match expected format: org/repo#number

Please contact an administrator to resolve this issue.

openshift-ci[bot] commented 4 months ago

@vr4manta: This PR was included in a payload test run from openshift/installer#8638 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1f56c190-42c3-11ef-979b-fd3d1ac6e09d-0

vr4manta commented 4 months ago

@jsafrane I ran a payload test in installer PR with these changes to show the changes being activated with new yaml cloud provider config. Here is the job: https://pr-payload-tests.ci.openshift.org/runs/ci/1f56c190-42c3-11ef-979b-fd3d1ac6e09d-0

openshift-ci[bot] commented 4 months ago

@vr4manta: This PR was included in a payload test run from openshift/installer#8638 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c4be700-484b-11ef-85be-87aff7ba424e-0

vr4manta commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@vr4manta: This PR was included in a payload test run from openshift/installer#8638 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ccf43180-49f7-11ef-9f37-1a9a541fff82-0

openshift-ci[bot] commented 4 months ago

@vr4manta: This PR was included in a payload test run from openshift/installer#8638 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c5fb600-49f9-11ef-946e-995bd153e893-0

jcpowermac commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

@vr4manta: This PR was included in a payload test run from openshift/installer#8638 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bc9f2a10-4a88-11ef-8514-9d45e18b94f9-0

vr4manta commented 4 months ago

/retest-required

vr4manta commented 4 months ago

@jsafrane , this PR is ready for approval. Have you been able to do the testing you wanted? Thanks!

vr4manta commented 4 months ago

@jsafrane nvm, looks like another merge conflict. I'll resolve that real quick.

jcpowermac commented 3 months ago

/lgtm

gnufied commented 3 months ago

/retest

gnufied commented 3 months ago

/lgtm

duanwei33 commented 3 months ago

/label qe-approved

openshift-ci-robot commented 3 months ago

@vr4manta: This pull request references SPLAT-1658 which is a valid jira issue.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/158): >[SPLAT-1658](https://issues.redhat.com/browse/SPLAT-1658) > >### Changes >- Added support for YAML config files >- Enhanced logic to handle multiple vCenters for various checks >- Created new checker to verify infrastructure config and cloud provider config >- Updated unit tests > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
duanwei33 commented 3 months ago

See test step in https://issues.redhat.com/browse/STOR-1814

jcpowermac commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
gnufied commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [gnufied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: vsphere-problem-detector This PR has been included in build ose-vsphere-problem-detector-container-v4.18.0-202408081451.p0.gcd0df71.assembly.stream.el9. All builds following this will include this PR.