search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

[release-4.16] OCPBUGS-35446: Fix missing failure-domains #160

Closed openshift-cherrypick-robot closed 5 months ago

openshift-cherrypick-robot commented 5 months ago

This is an automated cherry-pick of #159

/assign gnufied

/cherrypick release-4.15 release-4.14

openshift-ci-robot commented 5 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35215 has been cloned as Jira Issue OCPBUGS-35446. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-35446: Fix missing failure-domains

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/160): >This is an automated cherry-pick of #159 > >/assign gnufied > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 5 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35446, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/160): >This is an automated cherry-pick of #159 > >/assign gnufied > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-csi-extended 5404b2e013a55f3d13b36e00b506b312a74d2f32 link false /test e2e-vsphere-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
gnufied commented 5 months ago

/lgtm

gnufied commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@gnufied: This pull request references Jira Issue OCPBUGS-35446, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/160#issuecomment-2168200718): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
gnufied commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@gnufied: This pull request references Jira Issue OCPBUGS-35446, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-35215](https://issues.redhat.com//browse/OCPBUGS-35215) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-35215](https://issues.redhat.com//browse/OCPBUGS-35215) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/160#issuecomment-2168203591): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
gnufied commented 5 months ago

/label backport-risk-assessed

duanwei33 commented 5 months ago

Reproduce with latest 4.16:

  1. Removing the failureDomains in infrastructures manually (I tried both specifying the failureDomains or not in install-config, it always get the specified failureDomains or generated one in infrastructures)
  2. Create a storageclass with a valid datastoreurl
  3. Error found in vsphere-problem-detector: unable to find datastore with URL ds:///vmfs/volumes/xxxxxxxxxxxxx

Pre-merge verified with the open PR, issue not reproduced.

duanwei33 commented 5 months ago

/label qe-approved /label cherry-pick-approved

openshift-ci-robot commented 5 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35446, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-35215](https://issues.redhat.com//browse/OCPBUGS-35215) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-35215](https://issues.redhat.com//browse/OCPBUGS-35215) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/160): >This is an automated cherry-pick of #159 > >/assign gnufied > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jsafrane commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/release-4.16/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35446: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35446 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/160): >This is an automated cherry-pick of #159 > >/assign gnufied > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 5 months ago

@openshift-cherrypick-robot: new pull request created: #161

In response to [this](): >This is an automated cherry-pick of #159 > >/assign gnufied > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vsphere-problem-detector-container-v4.16.0-202406181107.p0.g9578848.assembly.stream.el9 for distgit vsphere-problem-detector. All builds following this will include this PR.

openshift-merge-robot commented 5 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-06-18-130927