search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

OCPBUGS-34563: Drop event when CheckDefaultDatastore fails #165

Closed bertinatto closed 4 months ago

bertinatto commented 4 months ago

Log a warning instead.

CC @openshift/storage

openshift-ci-robot commented 4 months ago

@bertinatto: This pull request references Jira Issue OCPBUGS-34563, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/165): >Log a warning instead. > >CC @openshift/storage > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [bertinatto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bertinatto commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@bertinatto: This pull request references Jira Issue OCPBUGS-34563, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/165#issuecomment-2226230303): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
gnufied commented 4 months ago

/lgtm

bertinatto commented 4 months ago

/label docs-approved /label px-approved This is not a user-facing change.

duanwei33 commented 4 months ago

/label qe-approved

openshift-ci-robot commented 4 months ago

@bertinatto: This pull request references Jira Issue OCPBUGS-34563, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/165): >Log a warning instead. > >CC @openshift/storage > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD e4de7774b24dc537bfd39b23329285aaea13d142 and 2 for PR HEAD 8574ea61dd3d708e2e8fe42bdfa8cc1f7f30093f in total

bertinatto commented 4 months ago

/retest-required

bertinatto commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-csi-extended 8574ea61dd3d708e2e8fe42bdfa8cc1f7f30093f link false /test e2e-vsphere-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bertinatto commented 4 months ago

/retest-required

openshift-ci-robot commented 4 months ago

@bertinatto: Jira Issue OCPBUGS-34563: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34563 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/165): >Log a warning instead. > >CC @openshift/storage > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

Distgit: vsphere-problem-detector This PR has been included in build ose-vsphere-problem-detector-container-v4.17.0-202407200643.p0.g30532cd.assembly.stream.el9. All builds following this will include this PR.

bertinatto commented 4 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 4 months ago

@bertinatto: new pull request created: #168

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/165#issuecomment-2259035523): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.