search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

STOR-1767: Silence vsphere-problem-detector if State is Removed #169

Closed mpatlasov closed 3 months ago

mpatlasov commented 4 months ago

vsphere-problem-detector must not emit any events if State is Removed in ClusterCSIDriver. Also, it must use klog.Infof() instead of klog.Errorf() in this case.

openshift-ci-robot commented 4 months ago

@mpatlasov: This pull request references STOR-1767 which is a valid jira issue.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/169): >vsphere-problem-detector must not emit any events if State is Removed in ClusterCSIDriver. Also, it must use `klog.Infof()` instead of `klog.Errorf()` in this case. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [mpatlasov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mpatlasov commented 4 months ago

/assign @jsafrane

mpatlasov commented 3 months ago

/label docs-approved /label px-approved

openshift-ci[bot] commented 3 months ago

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
gnufied commented 3 months ago

/lgtm

Phaow commented 3 months ago

/label qe-approved

openshift-ci-robot commented 3 months ago

@mpatlasov: This pull request references STOR-1767 which is a valid jira issue.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/169): >vsphere-problem-detector must not emit any events if State is Removed in ClusterCSIDriver. Also, it must use `klog.Infof()` instead of `klog.Errorf()` in this case. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fvsphere-problem-detector). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: vsphere-problem-detector This PR has been included in build ose-vsphere-problem-detector-container-v4.18.0-202408080513.p0.g52fd3c6.assembly.stream.el9. All builds following this will include this PR.