search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

Bug 1916379: Change metric for errors to gauge #24

Closed gnufied closed 3 years ago

gnufied commented 3 years ago

It is very tricky to report alerts on metrics that are emitted sporadically or at very long interval. Using gauge for this type simplifies alerting logic.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1916379

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [gnufied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 years ago

@gnufied: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere d0d66dc7a2433ed846da4adcc3ca10e536d2c802 link /test e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jsafrane commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

@gnufied: This pull request references Bugzilla bug 1916379, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.7.0) matches configured target release for branch (4.7.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/24): >Bug 1916379: Change metric for errors to gauge Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

@gnufied: All pull requests linked via external trackers have merged:

Bugzilla bug 1916379 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/24): >Bug 1916379: Change metric for errors to gauge Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.