search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

Bug 1919336: Check if datastore belongs to a datastore cluster #28

Closed gnufied closed 3 years ago

gnufied commented 3 years ago

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1919336

Output after the change:

I0208 17:00:29.199915  150092 operator.go:251] CheckDefaultDatastore failed: defaultDatastore "team-ssd-intel" in vSphere configuration: datastore team-ssd-intel is part of intel-ds-cluster datastore cluster
openshift-ci-robot commented 3 years ago

@gnufied: This pull request references Bugzilla bug 1919336, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/28): >WIP: Bug 1919336: Check if datastore belongs to a datastore cluster Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [gnufied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gnufied commented 3 years ago

/bugzilla refresh

openshift-ci-robot commented 3 years ago

@gnufied: This pull request references Bugzilla bug 1919336, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.8.0) matches configured target release for branch (4.8.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/28#issuecomment-775289895): >/bugzilla refresh > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

@gnufied: This pull request references Bugzilla bug 1919336, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/28): >Bug 1919336: Check if datastore belongs to a datastore cluster Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 3 years ago

/bugzilla refresh

openshift-ci-robot commented 3 years ago

@gnufied: This pull request references Bugzilla bug 1919336, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.8.0) matches configured target release for branch (4.8.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/28#issuecomment-775298543): >/bugzilla refresh > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 3 years ago

@jsafrane fixed the comments. PTAL

jsafrane commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

@gnufied: All pull requests linked via external trackers have merged:

Bugzilla bug 1919336 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/28): >Bug 1919336: Check if datastore belongs to a datastore cluster Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.