Bug 1959546: Update to current master

jsafrane commented 3 years ago

As part of bug #1959546 and 1934180, it makes sense to merge current master branch.

Benefits:

Unit test coverage (most of the Files changed are XMLs for simulated vCenter that we use for unit tests).
Bugfixes (perhaps more than the two above).
As you can see below, the nr. of commits that we merge here is not that big.

Risks:

Newer govc version 0.23 (another big chunk of Files changed)

WIP: ~* needs discussion with QA~

openshift-ci[bot] commented 3 years ago

@jsafrane: This pull request references Bugzilla bug 1959546, which is invalid:

expected the bug to target the "4.7.z" release, but it targets "4.8.0" instead
expected dependent Bugzilla bug 1943719 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/40): >WIP: Bug 1959546: Update to current master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/release-4.7/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 3 years ago

@jsafrane: This pull request references Bugzilla bug 1959546, which is invalid:

expected the bug to target the "4.7.z" release, but it targets "4.8.0" instead
expected dependent Bugzilla bug 1943719 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/40): >Bug 1959546: Update to current master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jsafrane commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@jsafrane: This pull request references Bugzilla bug 1959546, which is invalid:

expected dependent Bugzilla bug 1961718 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (DUPLICATE) instead
expected dependent Bugzilla bug 1961718 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/40#issuecomment-843241312): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jsafrane commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@jsafrane: This pull request references Bugzilla bug 1959546, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target release (4.7.z) matches configured target release for branch (4.7.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 1943719](https://bugzilla.redhat.com/show_bug.cgi?id=1943719) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE)) * dependent [Bugzilla bug 1943719](https://bugzilla.redhat.com/show_bug.cgi?id=1943719) targets the "4.8.0" release, which is one of the valid target releases: 4.8.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/40#issuecomment-843242422): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

gnufied commented 3 years ago

I tested this on a 4.7 cluster where I was using datastore cluster and it seems be working:

521 02:14:49.160183 1 datastore.go:56] CheckStorageClasses: dsc: datastore team-ssd-intel is part of intel-ds-cluster datastore cluster I0521 02:14:49.160200 1 datastore.go:67] CheckStorageClasses checked 2 storage classes, 1 problems found I0521 02:14:49.160207 1 operator.go:241] CheckStorageClasses failed: StorageClass dsc: datastore team-ssd-intel is part of intel-ds-cluster datastore cluster

gnufied commented 3 years ago

/lgtm

sdodson commented 3 years ago

[patch-manager] I evaluated this last week and skipped it due to the size and the fact that the upstream bugs referenced only moved to MODIFIED on May 17th. Finally, we were constrained on capacity last week as well. We will re-evaluate when the merge window opens again later this week.

wking commented 3 years ago

We probably want openshift/cluster-storage-operator#169 to go in first anyway, so we remain covered in one way or another, and that PR is still waiting on lgtm/approval.

gnufied commented 3 years ago

@wking if we merge https://github.com/openshift/cluster-storage-operator/pull/169 first then - it will try to alert on metric that does not exist (which I think will result in no alerts but that is okay) . It may not matter in the end because both PRs needs to be picked.

openshift-ci[bot] commented 3 years ago

@jsafrane: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-storage-operator#169 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1959546 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/40): >Bug 1959546: Update to current master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift / vsphere-problem-detector

Bug 1959546: Update to current master #40