openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster

Apache License 2.0

10 stars 24 forks source link

Check for a new line in credentials when unable to connect to vCenter #41

Closed rvanderp3 closed 3 years ago

rvanderp3 commented 3 years ago

Description

Adding a check for a new line in credentials when unable to connect to vCenter.

Testing

Encode a credentials with echo and excluded -n. For example:
```
echo mypassword | base64 -w0
```
Update configmap vsphere-creds in kube-system

Monitor vsphere-problem-detector logs

E0514 13:32:25.504764       1 operator.go:138] Failed to run checks: failed to connect to vcenter.domain.com: password in credentials contains new line
I0514 13:32:25.505070       1 operator.go:152] Scheduled the next check in 1m0.377112854s (2021-05-14 13:33:22.454966225 +0000 UTC m=+62.914630440)

rvanderp3 commented 3 years ago

/test e2e-vsphere

rvanderp3 commented 3 years ago

/test e2e-vsphere

jsafrane commented 3 years ago

/lgtm

jsafrane commented 3 years ago

/approve

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment