search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

Bug 2000268: Block cluster upgrades #49

Closed gnufied closed 3 years ago

gnufied commented 3 years ago

This PR fixes https://bugzilla.redhat.com/show_bug.cgi?id=2000268

It will block cluster upgrades if one of the following conditions is met:

  1. One or more VMs are on HW version < 15
  2. One or more of ESXi hosts are on version < 6.7u3
  3. vCenter server is on version <6.7u3
openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [gnufied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsafrane commented 3 years ago

/retitle Bug 2000268: Block cluster upgrades

openshift-ci[bot] commented 3 years ago

@gnufied: This pull request references Bugzilla bug 2000268, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.0) matches configured target release for branch (4.9.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/49): >Bug 2000268: Block cluster upgrades Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 years ago

@gnufied: This pull request references Bugzilla bug 2000268, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.0) matches configured target release for branch (4.9.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/49): >Bug 2000268: Block cluster upgrades Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@gnufied: This pull request references Bugzilla bug 2000268, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.0) matches configured target release for branch (4.9.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/49#issuecomment-912717597): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 3 years ago

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci[bot] commented 3 years ago

@openshift-merge-robot: This pull request references Bugzilla bug 2000268, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/49#issuecomment-913407634): >/bugzilla refresh > > The requirements for Bugzilla bugs have changed, recalculating validity. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@gnufied: This pull request references Bugzilla bug 2000268, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.0) matches configured target release for branch (4.10.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/49#issuecomment-914442441): >/bugzilla refresh > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jsafrane commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

@gnufied: All pull requests linked via external trackers have merged:

Bugzilla bug 2000268 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/49): >Bug 2000268: Block cluster upgrades Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.