search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

Bug 2011903: Deferred logout after checks are run #60

Closed bostrt closed 3 years ago

bostrt commented 3 years ago

Resolves a slow vSphere session leak: https://bugzilla.redhat.com/show_bug.cgi?id=2011903

openshift-ci[bot] commented 3 years ago

@bostrt: This pull request references Bugzilla bug 2011903, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/60): >Bug 2011903: Deferred logout after checks are run Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bostrt commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@bostrt: This pull request references Bugzilla bug 2011903, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/60#issuecomment-938137866): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bostrt commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@bostrt: This pull request references Bugzilla bug 2011903, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.0) matches configured target release for branch (4.10.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/60#issuecomment-938141756): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bostrt commented 3 years ago

/assign @tsmetana

dobsonj commented 3 years ago

Good catch, looks like this issue has existed from the beginning. /lgtm /approve

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bostrt, dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [dobsonj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 years ago

@bostrt: All pull requests linked via external trackers have merged:

Bugzilla bug 2011903 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/60): >Bug 2011903: Deferred logout after checks are run Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bostrt commented 2 years ago

/cherry-pick release-4.7

openshift-cherrypick-robot commented 2 years ago

@bostrt: #60 failed to apply on top of branch "release-4.7":

Applying: Bug 2011903: Deferred logout after checks are run
Using index info to reconstruct a base tree...
A   pkg/operator/vsphere_check.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/operator/vsphere_check.go deleted in HEAD and modified in Bug 2011903: Deferred logout after checks are run. Version Bug 2011903: Deferred logout after checks are run of pkg/operator/vsphere_check.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2011903: Deferred logout after checks are run
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/60#issuecomment-993696544): >/cherry-pick release-4.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 2 years ago

/cherry-pick release-4.9

openshift-cherrypick-robot commented 2 years ago

@gnufied: #60 failed to apply on top of branch "release-4.9":

Applying: Bug 2011903: Deferred logout after checks are run
Using index info to reconstruct a base tree...
A   pkg/operator/vsphere_check.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/operator/vsphere_check.go deleted in HEAD and modified in Bug 2011903: Deferred logout after checks are run. Version Bug 2011903: Deferred logout after checks are run of pkg/operator/vsphere_check.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2011903: Deferred logout after checks are run
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/60#issuecomment-996801475): >/cherry-pick release-4.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.