search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

OCPBUGS-926: Resolve situations when an existing folder or resource pool is used at install-time. #87

Closed bostrt closed 2 years ago

bostrt commented 2 years ago

The main change in this PR include the addition of checking the Resource Pool privileges, in a similar style to how the ComputeCluster privileges are checked.

Another change in this PR includes when the ComputeCluster privileges are checked in accordance with our product docs here under propagation settings. Basically, ComputeCluster privileges only need ReadOnly when a pre-existing ResourcePool has been defined.

I've also reduced the Datacenter privileges required down to ReadOnly since after installation, the long list of privileges aren't required and ReadOnly is all that's needed.

openshift-ci-robot commented 2 years ago

@bostrt: This pull request references Jira Issue OCPBUGS-926, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/87): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 2 years ago

/assign @rvanderp3

bostrt commented 2 years ago

/test e2e-vsphere-zones

openshift-ci[bot] commented 2 years ago

@bostrt: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/87#issuecomment-1249820942): >/test e2e-vsphere-zones Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jsafrane commented 2 years ago

/assign @gnufied

openshift-ci-robot commented 2 years ago

@bostrt: This pull request references Jira Issue OCPBUGS-926, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/87): >The main change in this PR include the addition of checking the Resource Pool privileges, in a similar style to how the ComputeCluster privileges are checked. > >Another change in this PR includes when the ComputeCluster privileges are checked in accordance with our product docs [here](https://docs.openshift.com/container-platform/4.11/installing/installing_vsphere/installing-vsphere-installer-provisioned.html#installation-vsphere-installer-infra-requirements_installing-vsphere-installer-provisioned) under propagation settings. Basically, ComputeCluster privileges only need ReadOnly when a pre-existing ResourcePool has been defined. > >I've also reduced the Datacenter privileges required down to ReadOnly since after installation, the long list of privileges aren't required and ReadOnly is all that's needed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bostrt commented 2 years ago

/test e2e-vsphere

bostrt commented 2 years ago

/jira refresh

openshift-ci-robot commented 2 years ago

@bostrt: This pull request references Jira Issue OCPBUGS-926, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.0) matches configured target version for branch (4.12.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/87#issuecomment-1252459578): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rvanderp3 commented 2 years ago

/test e2e-vsphere-zones

@bostrt we can add this test. I'll create a card for this.

bostrt commented 2 years ago

/hold until https://github.com/openshift/release/pull/32466 merges

bostrt commented 2 years ago

/test e2e-vsphere-zones

bostrt commented 2 years ago

e2e-vsphere-zones is hooked in now /unhold

bostrt commented 2 years ago

/test e2e-vsphere-zones

rvanderp3 commented 2 years ago

checked test results and took another pass after my last review. this looks good to go to me.

/lgtm

gnufied commented 2 years ago

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bostrt, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [gnufied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 0 against base HEAD f0b3ec94d9dff050460eb62bc8023f32596aa7ea and 2 for PR HEAD fee8fdc4a5ff0851af462bd6723fbffa1247cf8d in total

gnufied commented 2 years ago

/label docs-approved /label qe-approved

gnufied commented 2 years ago

/retest-required

jsafrane commented 2 years ago

/retest-required

openshift-ci[bot] commented 2 years ago

@bostrt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-zones fee8fdc4a5ff0851af462bd6723fbffa1247cf8d link false /test e2e-vsphere-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bostrt commented 2 years ago

/retest-required

openshift-ci-robot commented 2 years ago

@bostrt: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-926 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/87): >The main change in this PR include the addition of checking the Resource Pool privileges, in a similar style to how the ComputeCluster privileges are checked. > >Another change in this PR includes when the ComputeCluster privileges are checked in accordance with our product docs [here](https://docs.openshift.com/container-platform/4.11/installing/installing_vsphere/installing-vsphere-installer-provisioned.html#installation-vsphere-installer-infra-requirements_installing-vsphere-installer-provisioned) under propagation settings. Basically, ComputeCluster privileges only need ReadOnly when a pre-existing ResourcePool has been defined. > >I've also reduced the Datacenter privileges required down to ReadOnly since after installation, the long list of privileges aren't required and ReadOnly is all that's needed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.