search

openshift / vsphere-problem-detector

OpenShift operator that monitors & reports issues with vSphere cluster
Apache License 2.0
10 stars 24 forks source link

STOR-1019: Bump to k8s 1.26 libs for OCP 4.13 #99

Closed bertinatto closed 1 year ago

bertinatto commented 1 year ago

This patches bumps library-go, which in turn updates to k8s 1.26 libs:

go get github.com/openshift/library-go && go mod tidy && go mod vendor

This also pulls in https://github.com/openshift/library-go/pull/1460, which bumps golang.org/x/net v0.5.0 and addresses a CVE.

In addition to that, this patch includes commits to:

CC @openshift/storage

openshift-ci-robot commented 1 year ago

@bertinatto: This pull request references STOR-1019 which is a valid jira issue.

In response to [this](https://github.com/openshift/vsphere-problem-detector/pull/99): >This patches bumps `library-go`, which in turn updates to k8s 1.26 libs: > >`go get github.com/openshift/library-go && go mod tidy && go mod vendor` > >This also pulls in https://github.com/openshift/library-go/pull/1460, which bumps `golang.org/x/net` v0.5.0 and addresses a CVE. > >In addition to that, this patch includes commits to: > >- Update to Go 1.19 >- Bump legacy-cloud-providers dependency > >CC @openshift/storage > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jsafrane commented 1 year ago

/lgtm /approve /retest-required

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/vsphere-problem-detector/blob/master/OWNERS)~~ [bertinatto,jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bertinatto commented 1 year ago

/retest-required The OAuth issue has been fixed in our CI.

openshift-ci[bot] commented 1 year ago

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-zones ca7e5bb66e48282503511166da6db4a868383692 link false /test e2e-vsphere-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bertinatto commented 1 year ago

/label docs-approved /label px-approved /label qe-approved

This is not a user-facing change. Also, discussed with the team offline and we agreed that CI should be enough for testing this change.