openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

Import of existing codebase (WildFly and WildFly Core) ends with "Error calling service" and "Something went wrong" #1832

Open rsvoboda opened 6 years ago

rsvoboda commented 6 years ago

Import of existing codebase (WildFly and WildFly Core) ends with "Error calling service" and "Something went wrong"

Using space https://openshift.io/rsvoboda@redhat.com/foooooooooooooooo Time-stamp: 2018-01-10 13-33-01 CET

screenshot from 2018-01-10 13-33-01

ldimaggi commented 6 years ago

Can you provide the following information:

rsvoboda commented 6 years ago

I think the problem is that https://github.com/wildfly/wildfly and https://github.com/wildfly/wildfly-core do not have Jenkinsfile in repo.

Some safety check should be in place.

Yes for Confirm that this was attempted on https://openshift.io and Were any errors logged in the Chrome browser consoleThe rest can, see attached screenshot

gastaldi commented 6 years ago

@GeorgeActon @krishnapaparaju can you assign someone to look into this?

krishnapaparaju commented 6 years ago

@rsvoboda do you still see this issue ?

rsvoboda commented 6 years ago

yes, created new space, 'Welcome to your abcd space.' wizard opened, For 'How would you like to get started?' I selected 'Import existing code'. Chose my fork of https://github.com/wildfly/wildfly

screen shot 2018-03-25 at 17 43 07
bartoszmajsak commented 6 years ago

@rsvoboda The import flow and backend services has been significantly changed since the last time you tried. I just imported successfully both wildfly and wildfly-core repositories. It took a while, but I have them in OSIO right now. Build fails for both, but that's a different problem I believe.

Can you verify on your side and close this issue if that is no longer a case for you?

rsvoboda commented 6 years ago

Hi @bartoszmajsak, I was able to import wildfly-core, but with wildfly is have no luck.

I received 0 - {"isTrusted":true} message in top right corner when importing the wildfly project. I tried 2 pipelines (the shortest and the longest ones) in Select Pipeline step.

bartoszmajsak commented 6 years ago

Many thanks for spending your time checking this behavior @rsvoboda.

I received 0 - {"isTrusted":true} message in top right corner when importing the wildfly project.

At which point of the import flow this result shows up?

Could maybe try to reset your enviroment and do the import of wildfly starting from scratch? Assuming you don't have anything important to lose simply go to https://openshift.io/_profile/_cleanup

I will check on my side too.

rsvoboda commented 6 years ago

Clenup done, fresh import failed too

screen shot 2018-08-16 at 13 02 14

bartoszmajsak commented 6 years ago

@rsvoboda how many hooks do you have for that repo? What I see in the error logs in your case is following:

[{"resource":"Hook","code":"custom","message":"The \"push\" event cannot have more than 20 hooks"},{"resource":"Hook","code":"custom","message":"The \"pull_request\" event cannot have more than 20 hooks"}],"documentation_url":"https://developer.github.com/v3/repos/hooks/#create-a-hook"}

I tried importing this repo too and got hit by the error. After peeking into network console though I see that mine fails due to client timeout after 30s.

@gastaldi I think we have to make this call async to start. This is a huge repo to suck in but it would be also good to understand what can be improved in the service itself as we don't really do much with the content yet (correct if I'm wrong here).

As for the error message - I got is the same 0 - {"isTrusted":true} - @joshuawilson @christianvogt is that something on your radar - to improve error messages? This is not only puzzling for the user, but also for us to troubleshoot.

rsvoboda commented 6 years ago

My https://github.com/rsvoboda/wildfly/settings/hooks looks like a mess :). Have there 20 inactive/failed versioneye.com hooks (connection timeout), cleaning it now and will try the import again.

rsvoboda commented 6 years ago

hmm, I got 0 - {"isTrusted":true} again even with clean https://github.com/rsvoboda/wildfly/settings/hooks

gastaldi commented 6 years ago

@gastaldi I think we have to make this call async to start

The call is asynchronous already when the Import Application button is pressed. As for the number of webhooks, https://github.com/fabric8-launcher/launcher-backend/blob/master/addons/osio-addon/src/main/java/io/fabric8/launcher/osio/steps/GitSteps.java#L96 should check if the creation should happen, but maybe there is a hidden bug in there (supposing that the webhooks were created recently by launcher)

gastaldi commented 6 years ago

Ah the webhooks were versioneye hooks, ignore my last statement :)

bartoszmajsak commented 6 years ago

@rsvoboda I think this might be timeout I'm facing too. Did you see http call by any chance?

@gastaldi let's take it from there and have a look together on what to improve. The timeout is there so not sure if it's async or not.

rsvoboda commented 6 years ago

I went back to https://openshift.io/ and I saw https://github.com/rsvoboda/wildfly in Codebases section of the my wf-import space. So it seems to be the timeout issue.

I nuked my stuff via _cleanup and tried again, I received 0 - {"isTrusted":true}, but new hook was added to https://github.com/rsvoboda/wildfly/settings/hooks and after some time I could see https://github.com/rsvoboda/wildfly in Codebases section of the my wf-import space. Pipeline was triggered and it failed, but that's different story.

bartoszmajsak commented 6 years ago

Thanks again @rsvoboda for bearing with us and nailing down the problem. Keeping it open until we solve the timeout issue.

joshuawilson commented 6 years ago

Thanks for bringing it up. I was not aware.

bartoszmajsak commented 6 years ago

For the record, here are the stats for both repositories:

https://github.com/wildfly/wildfly-core (1.12 GiB)

| Name                         | Value     | Level of concern               |
| ---------------------------- | --------- | ------------------------------ |
| Overall repository size      |           |                                |
| * Commits                    |           |                                |
|   * Count                    |  14.9 k   |                                |
|   * Total size               |  5.22 MiB |                                |
| * Trees                      |           |                                |
|   * Count                    |   216 k   |                                |
|   * Total size               |  73.2 MiB |                                |
|   * Total tree entries       |  1.69 M   |                                |
| * Blobs                      |           |                                |
|   * Count                    |  79.4 k   |                                |
|   * Total size               |  1.12 GiB |                                |
| * Annotated tags             |           |                                |
|   * Count                    |     8     |                                |
| * References                 |           |                                |
|   * Count                    |   254     |                                |
|                              |           |                                |
| Biggest objects              |           |                                |
| * Commits                    |           |                                |
|   * Maximum size         [1] |  4.71 KiB |                                |
|   * Maximum parents      [2] |     7     |                                |
| * Trees                      |           |                                |
|   * Maximum entries      [3] |   175     |                                |
| * Blobs                      |           |                                |
|   * Maximum size         [4] |  8.68 MiB |                                |
|                              |           |                                |
| History structure            |           |                                |
| * Maximum history depth      |  9.86 k   |                                |
| * Maximum tag depth      [5] |     1     |                                |
|                              |           |                                |
| Biggest checkouts            |           |                                |
| * Number of directories  [6] |  1.88 k   |                                |
| * Maximum path depth     [6] |    21     | **                             |
| * Maximum path length    [6] |   166 B   | *                              |
| * Number of files        [7] |  5.08 k   |                                |
| * Total size of files    [8] |  60.1 MiB |                                |
| * Number of symlinks         |     0     |                                |
| * Number of submodules       |     0     |                                |

[1]  310f98fd837e039e0a705edc0e60ff2c647305a2
[2]  2a535b6bcccd71f4830889736ebf09648f4056a0
[3]  34943b33c5f0ed79b3426f6abf18411eb157811b (359cba2366ce7f2cad778c20561bf517342c4d3f:server/src/main/java/org/jboss/as/model)
[4]  6023ec4c66b6edf7e9fdbc0da7f8b7bed655066d (2f8805bff5ca400a372240303f49347d3cb6bd99:controller/src/test/resources/legacy-models/standalone-resource-definition-8.0.0.Final.dmr)
[5]  ff565c4490aec708243ad86e7b8e26fcce2f5cfc (refs/tags/1.0.0.Alpha1)
[6]  9761d933996fd4189ce1b6a9843180da46e1b12b (refs/heads/master^{tree})
[7]  cb74cbe2d369cdbb354ae1780e3cec1270245fbd (e6f76f6af38256905d34562d90f6709ef97dc6db^{tree})
[8]  553fcfcf86750a053ad9296f8173b5f33bea6e8c (cb152c4791febee6e2dcc4462a8e1d6a3d7762ac^{tree})

Current checkout (master)

╰─ du -sh .git/
80M .git/

https://github.com/wildfly/wildfly (2.58 GiB)

| Name                         | Value     | Level of concern               |
| ---------------------------- | --------- | ------------------------------ |
| Overall repository size      |           |                                |
| * Commits                    |           |                                |
|   * Count                    |  27.7 k   |                                |
|   * Total size               |  8.78 MiB |                                |
| * Trees                      |           |                                |
|   * Count                    |   456 k   |                                |
|   * Total size               |   156 MiB |                                |
|   * Total tree entries       |  3.96 M   |                                |
| * Blobs                      |           |                                |
|   * Count                    |   152 k   |                                |
|   * Total size               |  2.58 GiB |                                |
| * Annotated tags             |           |                                |
|   * Count                    |     2     |                                |
| * References                 |           |                                |
|   * Count                    |    97     |                                |
|                              |           |                                |
| Biggest objects              |           |                                |
| * Commits                    |           |                                |
|   * Maximum size         [1] |  4.66 KiB |                                |
|   * Maximum parents      [2] |     8     |                                |
| * Trees                      |           |                                |
|   * Maximum entries      [3] |   176     |                                |
| * Blobs                      |           |                                |
|   * Maximum size         [4] |  8.68 MiB |                                |
|                              |           |                                |
| History structure            |           |                                |
| * Maximum history depth      |  20.2 k   |                                |
| * Maximum tag depth      [5] |     1     |                                |
|                              |           |                                |
| Biggest checkouts            |           |                                |
| * Number of directories  [6] |  5.03 k   | **                             |
| * Maximum path depth     [6] |    21     | **                             |
| * Maximum path length    [6] |   182 B   | *                              |
| * Number of files        [7] |  11.7 k   |                                |
| * Total size of files    [8] |   107 MiB |                                |
| * Number of symlinks         |     0     |                                |
| * Number of submodules       |     0     |                                |

[1]  5bfb3f463914f54f6f3d1640739795b7a39cd34b
[2]  f4634935b7c57ce2516a9b9ace61892de8e339b8
[3]  eef3c3ca133ba0a8d7953e4128b532f2ba7525a2 (4f7ab1e21f05a2cbee1cae018f280b0d4e9c4f3f:domain/src/main/java/org/jboss/as/model)
[4]  6023ec4c66b6edf7e9fdbc0da7f8b7bed655066d (b5bd819948671bb0ecfd9e44198a769c6d66834b:controller/src/test/resources/legacy-models/standalone-resource-definition-8.0.0.Final.dmr)
[5]  3091769e4f40477293ce8706eca9c9b2a05a47d4 (refs/tags/7.0.0.Beta1-prerelease)
[6]  dc487c54886354ea38047916b165213dba0fa8e0 (refs/heads/master^{tree})
[7]  f0f53711b2815664c2fe2a206e7f8ebc28a5b0d7 (1979bf3f3a60f5f268b309504a4303a7adfbaf82^{tree})
[8]  dd3f451739fe0f198eca6daf9b6f5073bc6c9c76 (b0aa73c42d67f217e5ae9198ae88547c471f575b^{tree})

Current checkout (master)

╰─ du -sh .git/
203M    .git/

So we are dealing with quite a chunk here.