search

openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

Enable YAML langauge server by default in Che #2180

Open surajnarwade opened 6 years ago

surajnarwade commented 6 years ago

In order to use YAML completion or Kubernetes or Kedge support, we need the YAML language server, which is not enabled by default. The end user experience to enable this in the Che workspace settings as follows: screenshot from 2018-02-05 16-13-44

Post this, the pod gets restarted and then we can specify the setting for YAML completion under preferences.

This is really bad user experience, because there is no documentation for this behaviour! Also, under Profile -> Preferences -> Language Server Settings, the YAML settings are there, but it does not work for the same reason of missing documentation.

It would be great is we enable the YAML Language Server by default so the user can go about specifying the setting under Preferences without any other configurations.

PTAL, thanks!

CC: @containscafeine @jpinkney

ghost commented 6 years ago

@surajnarwade note that YAML LS won't work for all stacks, just for those with node.js installed.

concaf commented 6 years ago

@eivantsov but if we decide on installing dependencies as a resolution to #2179, then we can enable it by default? WDYT?

ghost commented 6 years ago

Yes, it is just a matter of workspace configuration.