search

openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

Avoid links to OpenShift Console Pipeline view #2207

Open hferentschik opened 6 years ago

hferentschik commented 6 years ago

Currently, there is a link from the Pipeline box on the Analyze page to the build pipeline view in the OpenShift Console:

analyze-pipeline

The link in the above screenshot refers to https://console.free-stg.openshift.com/console/project/hferents/browse/pipelines/demo-3-stage. It should just refer the internal pipeline view create/pipelines

pipelines

This relates to the rollout of the Jenkins Proxy/Idler - https://github.com/fabric8-services/fabric8-jenkins-proxy/issues/114

We should not have any links directly to the users Jenkins instance. In the OpenShift Console pipeline view, there is such a link to the build log files. We are working on getting this updated. See https://github.com/fabric8io/jenkins-sync-plugin/issues/11. This might take several days though. In the meantime, we could address the issue as well from the openshift.io UI by preventing the user to get to the OpenShift Console. Given that we have our own pipeline view there is no need for referring to the OpenShift Console anyways.

Note, the pipeline view of openshift.io has itself a link to the build logs which need to be updated. Instead of linking to the user's Jenkins instance, the link should be https://jenkins.prod-preview.openshift.io resp https://jenkins.openshift.io depending on the environment.

cc @vpavlin

hferentschik commented 6 years ago

There seems to be a concern that this removes a link to the OpenShift Console. That is correct, however, this link is implicit anyway. It is not obvious for the user that this is potential entry point to the OpenShift console and if no pipeline is defined this link does not even exist. So if access to the OpenShift Console is a concern, I suggest adding an explicit menu item (top level) to get to the OpenShift Console.

In general, the user should not have to leave the openshift.io UI. What's the point of linking from the homepage into the OpenShift Console pipeline view, if we have build our own pipeline view as well?

joshuawilson commented 6 years ago

@catrobson has your team been working on a new design or updated design of the pipelines page? What do you think of @hferentschik suggestions? cc @qodfathr

catrobson commented 6 years ago

We do not have any updated designs, no plans to tackle this right now. I'm good with Hardy's suggestions.

joshuawilson commented 6 years ago

cc @chmouel @sthaha

andrewazores commented 6 years ago

I believe this has been resolved. The Pipelines widget title link on the Analyze page now goes to a URL like this: http://localhost:3000/aazores@redhat.com/test-space/create/pipelines (local instance of course), rather than the OSO web console.