search

openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

Code refactoring: the recommender.py module from f8a-server-backbone repository #3202

Open tisnik opened 6 years ago

tisnik commented 6 years ago

RFE: code needs to be refactored in the recommender.py module from f8a-server-backbone repository. Namely those methods:

filter_versions

https://github.com/tisnik/f8a-server-backbone/blob/53fdd35f09673f3557da7b769acc024866356c1d/src/recommender.py#L149

execute

https://github.com/tisnik/f8a-server-backbone/blob/53fdd35f09673f3557da7b769acc024866356c1d/src/recommender.py#L413

You can use the following script https://github.com/fabric8-analytics/f8a-server-backbone/blob/master/list-todo.sh to list all functions that needs to be refactored:

src/utils.py:96:            # TODO: refactoring
src/stack_aggregator.py:166:    # TODO: refactoring
src/stack_aggregator.py:180:    # TODO: refactoring
src/stack_aggregator.py:240:    # TODO: refactoring
src/stack_aggregator.py:433:            # TODO: refactoring
src/recommender.py:167:        # TODO: refactoring
src/recommender.py:245:        # TODO: refactoring
src/recommender.py:311:    # TODO: refactoring
src/recommender.py:321:    # TODO: refactoring
src/recommender.py:344:    # TODO: refactoring
src/recommender.py:352:    # TODO: refactoring
src/recommender.py:429:        # TODO: refactoring
tisnik commented 6 years ago

@miteshvp @samuzzal-choudhury WDYT? Is it possible to work on this issue in the current sprint?

miteshvp commented 6 years ago

@tisnik - I will rather put it in the Backlog and if time permits, we can target in this sprint. Thanks for raising this.

tisnik commented 6 years ago

Thanks a lot @miteshvp . Let's move it into Backlog then :)

sara-02 commented 6 years ago

@tisnik A companion issue that I created in the repo https://github.com/fabric8-analytics/f8a-server-backbone/issues/69